Bug 216134 - Each step in Page::updateRendering() should use the same set of documents
Summary: Each step in Page::updateRendering() should use the same set of documents
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 202843
  Show dependency treegraph
 
Reported: 2020-09-03 11:23 PDT by Simon Fraser (smfr)
Modified: 2020-09-10 11:24 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-09-03 11:23:48 PDT
https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model implies that once you've collected the set of documents in step 11.1, you use that same set for all the subsequent steps.

We don't follow this; we call forEachDocument() at each step, so potentially we'll pick up a new document that was added by the previous step.
Comment 1 Ryosuke Niwa 2020-09-03 19:56:24 PDT
(In reply to Simon Fraser (smfr) from comment #0)
> https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-
> model implies that once you've collected the set of documents in step 11.1,
> you use that same set for all the subsequent steps.
> 
> We don't follow this; we call forEachDocument() at each step, so potentially
> we'll pick up a new document that was added by the previous step.

Right, I wanna make this code change with a test.
Comment 2 Radar WebKit Bug Importer 2020-09-10 11:24:13 PDT
<rdar://problem/68654053>