Bug 214640 - sRGB render targets not working
Summary: sRGB render targets not working
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Safari 13
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 212277 215844 215973
Blocks:
  Show dependency treegraph
 
Reported: 2020-07-22 07:01 PDT by jujjyl
Modified: 2020-09-09 11:13 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jujjyl 2020-07-22 07:01:28 PDT
STR:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/ext-sRGB.html?webglVersion=1&quiet=0&quick=1

Fails on two subsections

"Test the conversion of colors from linear to sRGB_ALPHA on framebuffer (texture) write"
"Test the conversion of colors from linear to sRGB on framebuffer (renderbuffer) write"

on macOS and iOS. We suspect that this causes incorrect brightness in rendering e.g. in Tiny Unity demo at

https://tiny.vision/demos/TinyRacing/Wasm/TinyRacing.html
Comment 1 jujjyl 2020-07-22 07:02:30 PDT
It looks like the same issue occurs on both WebGL 1 contexts when using the EXT_sRGB extension, and WebGL 2 contexts.
Comment 2 Radar WebKit Bug Importer 2020-07-22 09:39:02 PDT
<rdar://problem/65940663>
Comment 3 Kenneth Russell 2020-07-23 18:25:01 PDT
This has been fixed in Safari Technology Preview (Safari 14) with the ANGLE backend, likely via Bug 212277. Jukka, can you please confirm?
Comment 4 Kenneth Russell 2020-09-09 11:13:58 PDT
One of the earlier Safari Technology Previews ran Tiny Racing successfully, but the current one on macOS (Release 112 (Safari 14.0, WebKit 15610.1.25.5.1)) does have a regression where Tiny Racing renders black.

jdarpinian@ fixed two recent related bugs:

Implement WEBGL_compressed_texture_s3tc_srgb extension
https://bugs.webkit.org/show_bug.cgi?id=215973

and

WebGL goes in a bad state where glContext.createProgram() returns null
https://bugs.webkit.org/show_bug.cgi?id=215844

with those two fixes, top-of-tree WebKit at r266786 runs both Tiny Racing and https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/ext-sRGB.html?webglVersion=1 successfully.

Closing this report as WontFix since other bugs resolved it.