WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
214485
webkit-patch fails to land big patches
https://bugs.webkit.org/show_bug.cgi?id=214485
Summary
webkit-patch fails to land big patches
Carlos Alberto Lopez Perez
Reported
2020-07-17 10:36:13 PDT
Trying to manually land the patch from
bug 214414
failed with: $ Tools/Scripts/webkit-patch land -g HEAD Logging in as
clopez@igalia.com
... Fetching:
https://bugs.webkit.org/show_bug.cgi?id=214414
&ctype=xml&excludefield=attachmentdata Guessing "Chris Dumez" as reviewer from
attachment 404571
[details]
on
bug 214414
. Total errors found: 0 in 6 files COMMIT FAILED: [Errno 7] Argument list too long Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/steps/commit.py", line 89, in run svn_revision = scm.svn_revision_from_commit_text(commit_text) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 106, in svn_revision_from_commit_text return match.group('svn_revision') AttributeError: 'NoneType' object has no attribute 'group' This is likely caused because we are passing two many arguments to execve and causing an -E2BIG error. I tried setting "ulimit -s unlimited" but didn't helped. Linux has a hard 6MB limit on the arg stack size since
https://lore.kernel.org/patchwork/patch/807670/
... perhaps its related.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-07-24 10:37:17 PDT
<
rdar://problem/66061605
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug