RESOLVED FIXED 206842
WPT test importer only rewrites the first URL on <style> tags.
https://bugs.webkit.org/show_bug.cgi?id=206842
Summary WPT test importer only rewrites the first URL on <style> tags.
Carlos Alberto Lopez Perez
Reported 2020-01-27 13:27:25 PST
When importing WPT tests, the WebKit WPT importer tries to rewrite any URL() reference inside the <style> tags of the ref-tests to fix issues related to moving the ref-test to a new directory. But its currently only doing that for the first URL() reference it finds. Example: 1) WPT test css/css-backgrounds/css-border-radius-002.html has as test reference css/css-backgrounds/reference/css-border-radius-ref-002.html 2) WPT test importer imports css/css-backgrounds/reference/css-border-radius-ref-002.html as css/css-backgrounds/css-border-radius-002-expected.html 3) Since the ref-test has been moved to a different directory, it tries to update relative urls() on the <style> tag: Originally css-border-radius-ref-002.html had: <style type="text/css"> .redSquare { position: absolute; left:50px; width: 100px; height: 100px; background-image:url(../support/yyy.png); } .greenSquare { position: absolute; left:50px; width: 100px; height: 100px; background-image:url(../support/yy.png); } .container { position: absolute; } </style> Therefore, the style on css-border-radius-002-expected.html should have been rewrote as: <style type="text/css"> .redSquare { position: absolute; left:50px; width: 100px; height: 100px; background-image:url(support/yyy.png); } .greenSquare { position: absolute; left:50px; width: 100px; height: 100px; background-image:url(support/yy.png); } .container { position: absolute; } </style> The problem it is currently doing that only for the first URL (yyy.png) but not for the second (yy.png)
Attachments
Patch (7.30 KB, patch)
2020-01-27 14:03 PST, Carlos Alberto Lopez Perez
no flags
Carlos Alberto Lopez Perez
Comment 1 2020-01-27 14:03:17 PST
WebKit Commit Bot
Comment 2 2020-01-28 06:25:57 PST
Comment on attachment 388905 [details] Patch Clearing flags on attachment: 388905 Committed r255236: <https://trac.webkit.org/changeset/255236>
WebKit Commit Bot
Comment 3 2020-01-28 06:25:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-01-28 06:26:12 PST
Note You need to log in before you can comment on or make changes to this bug.