RESOLVED FIXED 205632
Create media mime type cache base class to reduce duplicate code 
https://bugs.webkit.org/show_bug.cgi?id=205632
Summary Create media mime type cache base class to reduce duplicate code
Eric Carlson
Reported Sunday, December 29, 2019 10:32:47 PM UTC
AVStreamDataParserMIMETypeCache and AVAssetMIMETypeCache have a lot of very similar code so create a base class so they can share.
Attachments
Patch (42.49 KB, patch)
2019-12-29 14:52 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (38.72 KB, patch)
2019-12-29 17:27 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (38.42 KB, patch)
2019-12-29 20:27 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (39.93 KB, patch)
2019-12-30 11:11 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 Sunday, December 29, 2019 10:33:00 PM UTC
<rdar://problem/58233565>
Eric Carlson
Comment 2 Sunday, December 29, 2019 10:52:47 PM UTC Comment hidden (obsolete)
Eric Carlson
Comment 3 Monday, December 30, 2019 1:27:00 AM UTC Comment hidden (obsolete)
Eric Carlson
Comment 4 Monday, December 30, 2019 4:27:13 AM UTC
Created attachment 386504 [details] Patch
Jer Noble
Comment 5 Monday, December 30, 2019 6:31:39 AM UTC
Comment on attachment 386504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386504&action=review r=me with nits. > Source/WebCore/platform/graphics/MIMETypeCache.h:48 > + WEBCORE_EXPORT void setSupportedTypes(const Vector<String>&); Nit: The implementation doesn’t match the name here. It doesn’t replace the existing set of supported types, instead it adds new types to the existing set. ‘addSupportedTypes’ maybe? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:263 > + if (AVStreamDataParserMIMETypeCache::singleton().isAvailable()) This could use a “auto cache = ...” so you’re not calling the singleton() method so much.
Eric Carlson
Comment 6 Monday, December 30, 2019 7:11:30 PM UTC
Created attachment 386541 [details] Patch
WebKit Commit Bot
Comment 7 Monday, December 30, 2019 8:51:54 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 386541 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 Monday, December 30, 2019 8:52:49 PM UTC
Comment on attachment 386541 [details] Patch Clearing flags on attachment: 386541 Committed r253952: <https://trac.webkit.org/changeset/253952>
WebKit Commit Bot
Comment 9 Monday, December 30, 2019 8:52:51 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.