Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010bca5db0 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebCore 0x000000011bb76b3b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x000000011de910f8 WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled() const + 104 (ActiveDOMObject.cpp:102) 3 com.apple.WebCore 0x000000011e0db9b4 WebCore::ScriptExecutionContext::checkConsistency() const + 820 4 com.apple.WebCore 0x000000011e0dc9e0 WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension(WTF::Vector<WebCore::ActiveDOMObject*, 0ul, WTF::CrashOnOverflow, 16ul>*) + 32 (ScriptExecutionContext.cpp:227) 5 com.apple.WebCore 0x000000011e2cc050 WebCore::canCacheFrame(WebCore::Frame&, WebCore::DiagnosticLoggingClient&, unsigned int) + 3504 (BackForwardCache.cpp:165)

<rdar://problem/57248130>

Looks like somebody forgot to call SuspendIfNeeded() for an ActiveDOMObject.

(In reply to Aakash Jain from comment #0) > Multiple mediacapturefromelement tests are crashing on mac debug (mojave, > high-sierra, Catalina), e.g.: > > fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html > fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > > > Build: > https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > r252500%20(6925)/results.html > > Flakiness dashboard: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout- > tests&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone- > track.html&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream- > creation.html&test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video- > dataavailable.html > > > Seems to be regression between r252500 and r252497. Probably > https://trac.webkit.org/changeset/252500/webkit It cannot be https://trac.webkit.org/changeset/252500/webkit

Actually, this is almost certainly r252497. Which was itself a fix for assertion failures.

(In reply to Alexey Proskuryakov from comment #5) > Actually, this is almost certainly r252497. Which was itself a fix for > assertion failures. Looking now.

Created attachment 383680 [details] Patch

Created attachment 383681 [details] Patch

Comment on attachment 383681 [details] Patch Clearing flags on attachment: 383681 Committed r252524: <https://trac.webkit.org/changeset/252524>

All reviewed patches have been landed. Closing bug.

It looks like fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html are still crashing

(In reply to Truitt Savell from comment #11) > It looks like > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > are still crashing Odd, will look now although it would help to get a link.

history: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone-track.html&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-creation.html Run with crashes: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r252541%20(707)/results.html

(In reply to Chris Dumez from comment #12) > (In reply to Truitt Savell from comment #11) > > It looks like > > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > > and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > > are still crashing > > Odd, will look now although it would help to get a link. I can reproduce the crash for fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html and will get a fix shortly.

Reopening for follow-up fix.

Created attachment 383751 [details] Patch

Comment on attachment 383751 [details] Patch Clearing flags on attachment: 383751 Committed r252545: <https://trac.webkit.org/changeset/252545>

All reviewed patches have been landed. Closing bug.