WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
200210
Import css/css-images WPT tests
https://bugs.webkit.org/show_bug.cgi?id=200210
Summary
Import css/css-images WPT tests
Simon Fraser (smfr)
Reported
2019-07-28 14:47:00 PDT
Import css/css-images WPT tests
Attachments
Patch
(183.83 KB, patch)
2019-07-28 14:48 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-highsierra
(3.20 MB, application/zip)
2019-07-28 15:56 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2
(2.68 MB, application/zip)
2019-07-28 16:04 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews117 for mac-highsierra
(2.75 MB, application/zip)
2019-07-28 16:38 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews210 for win-future
(13.48 MB, application/zip)
2019-07-28 16:43 PDT
,
EWS Watchlist
no flags
Details
Patch
(188.82 KB, patch)
2019-07-28 17:54 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(192.09 KB, patch)
2019-07-28 18:51 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews215 for win-future
(13.54 MB, application/zip)
2019-07-28 21:00 PDT
,
EWS Watchlist
no flags
Details
Patch
(198.61 KB, patch)
2019-10-10 11:31 PDT
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(7)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2019-07-28 14:48:04 PDT
Created
attachment 375046
[details]
Patch
EWS Watchlist
Comment 2
2019-07-28 15:56:48 PDT
Comment hidden (obsolete)
Comment on
attachment 375046
[details]
Patch
Attachment 375046
[details]
did not pass mac-ews (mac): Output:
https://webkit-queues.webkit.org/results/12826891
New failing tests: http/wpt/css/css-images/image-fit-001.xht http/wpt/css/css-images/multiple-position-color-stop-linear-2.html http/wpt/css/css-images/image-fit-006.xht http/wpt/css/css-images/multiple-position-color-stop-conic.html http/wpt/css/css-images/multiple-position-color-stop-radial-2.html
EWS Watchlist
Comment 3
2019-07-28 15:56:49 PDT
Comment hidden (obsolete)
Created
attachment 375048
[details]
Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 4
2019-07-28 16:04:36 PDT
Comment hidden (obsolete)
Comment on
attachment 375046
[details]
Patch
Attachment 375046
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
https://webkit-queues.webkit.org/results/12826892
New failing tests: http/wpt/css/css-images/image-fit-001.xht http/wpt/css/css-images/multiple-position-color-stop-linear-2.html http/wpt/css/css-images/image-fit-006.xht http/wpt/css/css-images/multiple-position-color-stop-conic.html http/wpt/css/css-images/multiple-position-color-stop-radial-2.html
EWS Watchlist
Comment 5
2019-07-28 16:04:37 PDT
Comment hidden (obsolete)
Created
attachment 375049
[details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 6
2019-07-28 16:37:59 PDT
Comment hidden (obsolete)
Comment on
attachment 375046
[details]
Patch
Attachment 375046
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/12826913
New failing tests: http/wpt/css/css-images/image-fit-001.xht http/wpt/css/css-images/multiple-position-color-stop-linear-2.html http/wpt/css/css-images/image-fit-006.xht http/wpt/css/css-images/multiple-position-color-stop-conic.html http/wpt/css/css-images/multiple-position-color-stop-radial-2.html
EWS Watchlist
Comment 7
2019-07-28 16:38:00 PDT
Comment hidden (obsolete)
Created
attachment 375051
[details]
Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 8
2019-07-28 16:43:15 PDT
Comment hidden (obsolete)
Comment on
attachment 375046
[details]
Patch
Attachment 375046
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/12826939
New failing tests: http/wpt/css/css-images/image-fit-001.xht http/wpt/css/css-images/multiple-position-color-stop-linear-2.html http/wpt/css/css-images/image-fit-006.xht http/wpt/css/css-images/multiple-position-color-stop-conic.html http/wpt/css/css-images/multiple-position-color-stop-radial-2.html
EWS Watchlist
Comment 9
2019-07-28 16:43:17 PDT
Comment hidden (obsolete)
Created
attachment 375052
[details]
Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Simon Fraser (smfr)
Comment 10
2019-07-28 17:54:50 PDT
Comment hidden (obsolete)
Created
attachment 375056
[details]
Patch
Simon Fraser (smfr)
Comment 11
2019-07-28 18:51:56 PDT
Created
attachment 375057
[details]
Patch
EWS Watchlist
Comment 12
2019-07-28 21:00:14 PDT
Comment on
attachment 375057
[details]
Patch
Attachment 375057
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/12827678
New failing tests: http/wpt/css/css-images/image-fit-001.xht http/wpt/css/css-images/image-fit-006.xht
EWS Watchlist
Comment 13
2019-07-28 21:00:16 PDT
Created
attachment 375059
[details]
Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Carlos Alberto Lopez Perez
Comment 14
2019-08-15 08:34:36 PDT
***
Bug 200716
has been marked as a duplicate of this bug. ***
Carlos Alberto Lopez Perez
Comment 15
2019-08-15 08:36:17 PDT
I found this bug because I was trying to import this tests also in
bug 200716
. Marked now as duplicated. I wonder why you are importing them inside the path LayoutTests/http/wpt instead of LayoutTests/imported/w3c/web-platform-tests ?
Simon Fraser (smfr)
Comment 16
2019-08-15 09:00:50 PDT
Is http/wpt the wrong place? Youenne?
Carlos Alberto Lopez Perez
Comment 17
2019-08-15 09:08:19 PDT
Comment on
attachment 375057
[details]
Patch The expectations for the tests css/css-images/multiple-position-color-stop-linear-2.html and css/css-images/multiple-position-color-stop-radial-2.html are wrongly imported. This are ref-tests and the expectation file should be an -expected.html and not an -expected.txt The issue here is that the W3C test importer is currently unable to correctly resolve the paths to the expectations of this tests because the expectation reference uses absolute paths. I suggest to apply the fix from
bug 200717
and re-run the import.
Carlos Alberto Lopez Perez
Comment 18
2019-08-27 13:30:53 PDT
(In reply to Carlos Alberto Lopez Perez from
comment #17
)
> Comment on
attachment 375057
[details]
> Patch > > The expectations for the tests > css/css-images/multiple-position-color-stop-linear-2.html and > css/css-images/multiple-position-color-stop-radial-2.html are wrongly > imported. > > This are ref-tests and the expectation file should be an -expected.html and > not an -expected.txt > > The issue here is that the W3C test importer is currently unable to > correctly resolve the paths to the expectations of this tests because the > expectation reference uses absolute paths. I suggest to apply the fix from >
bug 200717
and re-run the import.
Note: Fix for
bug 200717
has already landed in
r249139
youenn fablet
Comment 19
2019-08-28 10:23:10 PDT
(In reply to Simon Fraser (smfr) from
comment #16
)
> Is http/wpt the wrong place? Youenne?
http/wpt is the wrong place indeed. http/wpt are for tests that use WPT infrastructure but we do not sync them, for instance they use internals API. http/wpt tests are served as
http://localhost:8800/WebKit/
... imported/w3c/web-platform-tests is the way to go to import them.
youenn fablet
Comment 20
2019-08-28 10:23:29 PDT
Normally, the import-w3c-tests should import the tests in the right folder.
Simon Fraser (smfr)
Comment 21
2019-08-28 11:04:52 PDT
(In reply to youenn fablet from
comment #20
)
> Normally, the import-w3c-tests should import the tests in the right folder.
Is this documented anywhere?
Carlos Alberto Lopez Perez
Comment 22
2019-10-04 04:07:55 PDT
I think it will be great to import this tests and land the fix for the crash from
bug 200206
I can help with importing this tests if you want.
Simon Fraser (smfr)
Comment 23
2019-10-04 10:05:49 PDT
Help is welcome!
Carlos Alberto Lopez Perez
Comment 24
2019-10-10 11:29:22 PDT
I found another issue on the WPT importer, it was breaking the SVG files (
bug 202806
) In any case, I think I have the tests imported correctly now.. patch incoming
Carlos Alberto Lopez Perez
Comment 25
2019-10-10 11:31:22 PDT
Created
attachment 380665
[details]
Patch
Carlos Alberto Lopez Perez
Comment 26
2019-10-10 15:02:10 PDT
Comment on
attachment 380665
[details]
Patch Clearing flags on attachment: 380665 Committed
r250993
: <
https://trac.webkit.org/changeset/250993
>
Carlos Alberto Lopez Perez
Comment 27
2019-10-10 15:02:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 28
2019-10-10 15:03:32 PDT
<
rdar://problem/56171069
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug