RESOLVED FIXED 199852
run-safari --ios-simulator is no longer working with Xcode 11 
https://bugs.webkit.org/show_bug.cgi?id=199852
Summary run-safari --ios-simulator is no longer working with Xcode 11
Frédéric Wang (:fredw)
Reported 2019-07-17 03:17:43 PDT
XCode relase and beta use different paths for MobileSafari.app: $ find Xcode.app -name MobileSafari.app Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/Applications/MobileSafari.app $ find Xcode-beta.app -name MobileSafari.app Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/Applications/MobileSafari.app (note that "Developer" and "Library" have been switched) A trivial patch to make things work again is: diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm index 1374b4b3f2..c011655669 100755 --- a/Tools/Scripts/webkitdirs.pm +++ b/Tools/Scripts/webkitdirs.pm @@ -2503,7 +2503,7 @@ sub setupIOSWebKitEnvironment($) sub iosSimulatorApplicationsPath() { # FIXME: We should ask simctl for this information, instead of guessing from available runtimes. - my $runtimePath = File::Spec->catdir(sdkPlatformDirectory("iphoneos"), "Developer", "Library", "CoreSimulator", "Profiles", "Runtimes"); + my $runtimePath = File::Spec->catdir(sdkPlatformDirectory("iphoneos"), "Library", "Developer", "CoreSimulator", "Profiles", "Runtimes"); opendir(RUNTIMES, $runtimePath); my @runtimes = grep {/.*\.simruntime/} readdir(RUNTIMES); close(RUNTIMES); but of course that will break backward compatibility...
Attachments
Patch (1.61 KB, patch)
2019-09-26 13:54 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-26 03:26:17 PDT
<rdar://problem/55738122>
Frédéric Wang (:fredw)
Comment 2 2019-09-26 05:27:03 PDT
This bug now happens on Mojave with the recent XCode 11 release.
Jonathan Bedard
Comment 3 2019-09-26 07:22:13 PDT
We can totally break iOS 12 at this point, so the 'trivial patch' is probably the way to go.
Frédéric Wang (:fredw)
Comment 4 2019-09-26 13:54:22 PDT
Created attachment 379676 [details] Patch OK let's do that.
WebKit Commit Bot
Comment 5 2019-09-26 14:54:37 PDT
Comment on attachment 379676 [details] Patch Clearing flags on attachment: 379676 Committed r250400: <https://trac.webkit.org/changeset/250400>
WebKit Commit Bot
Comment 6 2019-09-26 14:54:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.