198695 – Make it possible to mark the value of an SVGProperty as 'Invalid'

NEW198695

Make it possible to mark the value of an SVGProperty as 'Invalid'

https://bugs.webkit.org/show_bug.cgi?id=198695

Summary Make it possible to mark the value of an SVGProperty as 'Invalid'

Said Abou-Hallawa

Reported 2019-06-08 18:37:12 PDT

SVGProperty can be initialized with the default value. Or it can be set to the default value as a fall back of parsing error. Marking the state to 'Invalid' will allow differentiating between these two cases.

Attachments
Patch (323.53 KB, patch) 2019-06-08 18:40 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch for review (15.81 KB, patch) 2019-07-10 10:38 PDT, Said Abou-Hallawa	sabouhallawa: review?	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2019-06-08 18:40:57 PDT

Created attachment 371692 [details] Patch

EWS Watchlist

Comment 2 2019-06-08 18:43:27 PDT

Attachment 371692 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 164 files If any of these errors are false positives, please file a bug against check-webkit-style.

Said Abou-Hallawa

Comment 3 2019-07-10 10:38:51 PDT

Created attachment 373847 [details] Patch for review

Ahmad Saleem

Comment 4 2022-08-13 15:59:33 PDT

I can see that at least on few sample files I looked into that this patch didn't landed because these changes are not done: EXAMPLES: -> These one not: https://github.com/WebKit/WebKit/blob/be8ef74127a13ec30f4a8ce4130eb29a9b55fb30/Source/WebCore/svg/SVGElement.cpp#L645 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L39 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L52 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L58 -> This one is slightly done: https://github.com/WebKit/WebKit/blob/be8ef74127a13ec30f4a8ce4130eb29a9b55fb30/Source/WebCore/svg/SVGElement.cpp#L645 _______ Is this needed or we can mark this as "RESOLVED LATER" or can rebase and land, if it fixes or improves web-compat or performance? Thanks!

Radar WebKit Bug Importer

Comment 5 2022-08-14 10:52:45 PDT

<rdar://problem/98641903>

Note You need to log in before you can comment on or make changes to this bug.

Status NEW

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component SVG

Assignee

Said Abou-Hallawa

Reported

2019-06-08 18:37 PDT

Modified

2022-08-14 10:52 PDT History

CC List

10 users Show

URL

Keywords InRadar

Depends on

Blocks