NEW198254
Clean up TiledBacking coverage and scrollability 
https://bugs.webkit.org/show_bug.cgi?id=198254
Summary Clean up TiledBacking coverage and scrollability
Simon Fraser (smfr)
Reported 2019-05-25 20:30:20 PDT
Clean up TiledBacking coverage and scrollability
Attachments
Patch (28.26 KB, patch)
2019-05-25 20:31 PDT, Simon Fraser (smfr) 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.72 MB, application/zip)
2019-05-25 21:57 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-05-25 20:31:01 PDT
Created attachment 370641 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-05-25 20:31:30 PDT
Parking this patch here. It's a bit too invasive to do now.
EWS Watchlist
Comment 3 2019-05-25 20:34:16 PDT
Attachment 370641 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:358: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:359: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:369: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/platform/graphics/TiledBacking.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 5 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 4 2019-05-25 21:57:00 PDT
Comment on attachment 370641 [details] Patch Attachment 370641 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12291522 New failing tests: tiled-drawing/tile-size-view-exposed-rect.html tiled-drawing/tile-coverage-view-exposed-rect.html
EWS Watchlist
Comment 5 2019-05-25 21:57:02 PDT
Created attachment 370644 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Note You need to log in before you can comment on or make changes to this bug.