WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
19604
Re-enable 7 working layout tests
https://bugs.webkit.org/show_bug.cgi?id=19604
Summary
Re-enable 7 working layout tests
Jean-Charles Verdié
Reported
2008-06-17 08:30:16 PDT
this patch re-enabled 7 working layout tests
Attachments
re-enable 7 layout tests
(51.40 KB, patch)
2008-06-17 08:32 PDT
,
Jean-Charles Verdié
darin
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jean-Charles Verdié
Comment 1
2008-06-17 08:32:36 PDT
Created
attachment 21755
[details]
re-enable 7 layout tests
Alexey Proskuryakov
Comment 2
2008-06-25 03:28:32 PDT
+ * http/tests/xmlhttprequest/web-apps/006-expected.txt: Added. Why is this file added without any changes to the test itself (not that I think that this test should be enabled)
Darin Adler
Comment 3
2008-10-12 16:47:18 PDT
Comment on
attachment 21755
[details]
re-enable 7 layout tests I don't think you did enough research on why these tests were disabled. For example, the two counters tests were disabled in <
http://trac.webkit.org/changeset/18642
> with this comment: "disabled 3 tests with results that are too font-dependent to be used as part of the test suite". So we can't just re-enable those tests unless we resolve the issue about getting appropriate fonts on everyone's computer. And fast/frames/iframe-scroll-page-up-down.html fails when I run it on my machine, so I don't agree that it's working. The crash that fast/images/svg-background-crash-on-refresh.html was causing was something that affected tests downstream. I'm not confident that bringing this patch back won't bring back the reason we turned it off in the first place; I'll need more evidence before doing that. The create-list-1.html test does not give the expected result that's checked in, so if we wanted to bring it back we'd have to fix the expected result. Overall, this patch isn't usable as-is. Changing to review-.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug