WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
19526
ASSERTION FAILED: m_numNodeListCaches
https://bugs.webkit.org/show_bug.cgi?id=19526
Summary
ASSERTION FAILED: m_numNodeListCaches
danceoffwithyourpantsoff
Reported
2008-06-12 15:54:23 PDT
var doc = document.implementation.createHTMLDocument('a'); Node's can cache nodelists in m_nodeLists. They keep a counter on their document, via document()->addNodeListCache and document()->removeNodeListCache. However, when a node is adopted between documents, nothing is done to keep this balance. On adoption, we should be clearing m_nodeLists and calling document()->removeNodeListCache. var b = document.createElement('b'); // Give it a node list cache on document b.childNodes; // Attach it to doc to update m_document doc.adoptNode(b); doc.body.appendChild(b); doc.body.removeChild(b); // GC here if you can, or reload the page to fire ~Node and cleanup m_nodeLists
Attachments
test case (will assert)
(345 bytes, text/html)
2008-06-12 21:49 PDT
,
Alexey Proskuryakov
no flags
Details
patch
(5.29 KB, patch)
2009-12-22 16:21 PST
,
Darin Adler
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2008-06-12 21:49:52 PDT
Created
attachment 21670
[details]
test case (will assert)
Alexey Proskuryakov
Comment 2
2008-06-12 21:50:58 PDT
Confirmed with
r34513
.
mitz
Comment 3
2009-11-29 17:28:42 PST
Are there any symptoms in release builds?
mitz
Comment 4
2009-11-30 15:52:55 PST
<
rdar://problem/7431572
>
Darin Adler
Comment 5
2009-12-22 14:49:09 PST
I see no reason to clear m_nodeLists.
Darin Adler
Comment 6
2009-12-22 16:21:45 PST
Created
attachment 45410
[details]
patch
WebKit Review Bot
Comment 7
2009-12-22 16:26:05 PST
style-queue ran check-webkit-style on
attachment 45410
[details]
without any errors.
Sam Weinig
Comment 8
2009-12-22 16:29:02 PST
Comment on
attachment 45410
[details]
patch
> \ No newline at end of file
r=me
Darin Adler
Comment 9
2009-12-22 16:51:17 PST
http://trac.webkit.org/changeset/52511
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug