RESOLVED FIXED 189352
Group options of scrollRectToVisible into a struct 
https://bugs.webkit.org/show_bug.cgi?id=189352
Summary Group options of scrollRectToVisible into a struct
Frédéric Wang (:fredw)
Reported 2018-09-06 08:05:45 PDT
RenderLayer::scrollRectToVisible and RenderObject::scrollRectToVisible have several parameters to configure the type of scrolling. We could group them into a single struct to make easier to modify parameters in the future (e.g. add an ifdefed scroll behavior option in bug 188043). Maybe this could help too for bug 176454 and bug 161611.
Attachments
Patch (24.63 KB, patch)
2018-09-06 08:29 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (25.23 KB, patch)
2018-09-06 09:15 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-09-06 08:29:04 PDT
Created attachment 349027 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-09-06 09:15:21 PDT
Created attachment 349030 [details] Patch
WebKit Commit Bot
Comment 3 2018-09-06 12:48:15 PDT
Comment on attachment 349030 [details] Patch Clearing flags on attachment: 349030 Committed r235749: <https://trac.webkit.org/changeset/235749>
WebKit Commit Bot
Comment 4 2018-09-06 12:48:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-06 12:49:27 PDT
<rdar://problem/44192485>
Note You need to log in before you can comment on or make changes to this bug.