RESOLVED FIXED 185658
[modern-media-controls] AirPlaySupport should be disabled by default 
https://bugs.webkit.org/show_bug.cgi?id=185658
Summary [modern-media-controls] AirPlaySupport should be disabled by default
Jer Noble
Reported 2018-05-15 14:45:39 PDT
AirPlaySupport inherits from MediaControllerSupport, which enables the support object at construction time. This means that the controls will always add a airplay route availability listener, even if they are invisible. They will be disabled eventually, but that's too late, as the listener has already kicked off the airplay route listening machinery.
Attachments
Patch (8.21 KB, patch)
2018-05-17 06:28 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-15 14:46:08 PDT
<rdar://problem/40272213>
Jer Noble
Comment 2 2018-05-15 14:46:27 PDT
Additionally, the AirPlaySupport object should remain disabled when displaying only the "big play button" on iOS, since there's no visible airplay route change button.
Antoine Quint
Comment 3 2018-05-17 06:28:05 PDT
Created attachment 340577 [details] Patch
WebKit Commit Bot
Comment 4 2018-05-17 08:34:43 PDT
Comment on attachment 340577 [details] Patch Clearing flags on attachment: 340577 Committed r231899: <https://trac.webkit.org/changeset/231899>
WebKit Commit Bot
Comment 5 2018-05-17 08:34:45 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6 2018-05-17 14:14:23 PDT
This change appears to have caused the following two LayoutTests to become flaky timeouts on macOS: media/modern-media-controls/scrubber-support/scrubber-support-drag.html media/modern-media-controls/volume-support/volume-support-click.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fscrubber-support%2Fscrubber-support-drag.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fvolume-support%2Fvolume-support-click.html
Ryan Haddad
Comment 7 2018-05-17 15:15:11 PDT
Reverted r231899 for reason: Caused flakiness in two existing modern-media-controls tests. Committed r231923: <https://trac.webkit.org/changeset/231923>
Ryan Haddad
Comment 8 2018-05-17 17:22:03 PDT
*** Bug 185751 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 9 2018-05-18 07:08:53 PDT
Committed r231950: <https://trac.webkit.org/changeset/231950>
Note You need to log in before you can comment on or make changes to this bug.