WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
184722
[TestWebKitAPI][Win] Rethink how createURLForResource gets the resource directory
https://bugs.webkit.org/show_bug.cgi?id=184722
Summary
[TestWebKitAPI][Win] Rethink how createURLForResource gets the resource direc...
Fujii Hironori
Reported
2018-04-17 18:08:17 PDT
[TestWebKitAPI][Win] Rethink how createURLForResource gets the resource directory (In reply to Alex Christensen from
bug #184524 comment #3
)
> > Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53 > > + String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension); > > This seems specific to a certain build configuration.
Mac port is copying the resource file into the build directory. GTK and WPE ports are using a env var to specify the source directory. Old WebKit port was using the same approach with Mac port.
https://trac.webkit.org/browser/webkit/trunk/Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp?rev=230744#L54
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug