RESOLVED DUPLICATE of bug 175067 183030
[GTK] Rendering issue with Google Calendar notification details 
https://bugs.webkit.org/show_bug.cgi?id=183030
Summary [GTK] Rendering issue with Google Calendar notification details
Xabier Rodríguez Calvar
Reported 2018-02-22 02:46:02 PST
Created attachment 334445 [details] Screenshot Steps: 1. Open Google Calendar 2. Open the details of an event 3. Check the notifications
Attachments
Screenshot (2.62 KB, image/png)
2018-02-22 02:46 PST, Xabier Rodríguez Calvar 		no flags
Details
Firefox rendering (3.06 KB, image/png)
2018-02-22 02:46 PST, Xabier Rodríguez Calvar 		no flags
Details
Patch (7.64 KB, patch)
2018-03-01 05:58 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Test to reproduce (130 bytes, text/html)
2018-05-08 05:56 PDT, Carlos Bentzen 		no flags
Details
Test to reproduce (144 bytes, text/html)
2018-05-08 05:58 PDT, Carlos Bentzen 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2018-02-22 02:46:35 PST
Created attachment 334446 [details] Firefox rendering
Xabier Rodríguez Calvar
Comment 2 2018-02-22 02:47:20 PST
This happens with 2.19.90.
Alejandro G. Castro
Comment 3 2018-03-01 05:58:18 PST
Created attachment 334811 [details] Patch
Alejandro G. Castro
Comment 4 2018-03-01 06:14:26 PST
Comment on attachment 334811 [details] Patch I added the patch here by mistake, sorry.
Miguel Gomez
Comment 5 2018-05-04 07:33:16 PDT
Actually I can see the rendering messed up in the whole page, and even a crash sometimes, with minibrowser and ToT
Carlos Bentzen
Comment 6 2018-05-08 05:56:51 PDT
Created attachment 339810 [details] Test to reproduce The test attached reproduces the situation here on Epiphany nightly and Minibrowser. The problem is the SpinButton from GTK theme which has pretty large dimensions, so to work around this, the GTK port resizes the text field element (or at least tries to) to avoid cases like this that hide the text field area. However, in some cases the resize doesn't work, like in Google Calendar notification example and the isolated reproduction. To continue using the GTK themes in those cases we could override RenderTheme::shouldHaveSpinButton to not draw the spinbuttons in those cases, I think. Otherwise, what about dropping the spinbutton from GTK and draw arrows like Firefox/Chromium does? (I think prior to GTK 3.20.0 it was doing it)
Carlos Bentzen
Comment 7 2018-05-08 05:58:50 PDT
Created attachment 339811 [details] Test to reproduce Ops, I sent a wrong attachment. This is the right one.
Michael Catanzaro
Comment 8 2018-06-01 10:43:54 PDT
(In reply to Carlos Eduardo Ramalho from comment #6) > To continue using the GTK themes in those cases we could override > RenderTheme::shouldHaveSpinButton to not draw the spinbuttons in those > cases, I think. Otherwise, what about dropping the spinbutton from GTK and > draw arrows like Firefox/Chromium does? (I think prior to GTK 3.20.0 it was > doing it) Either option seems OK. Using the GTK theme where possible is nicer and more desirable... but we'd need to be confident that it's not going to break websites like this.
Michael Catanzaro
Comment 9 2018-06-15 07:31:07 PDT
This is bug #175067. *** This bug has been marked as a duplicate of bug 175067 ***
Note You need to log in before you can comment on or make changes to this bug.