RESOLVED FIXED 182651
[RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=182651
Summary [RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a ...
zalan
Reported 2018-02-09 14:24:04 PST
ssia
Attachments
Patch (11.43 KB, patch)
2018-02-09 14:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.43 KB, patch)
2018-02-09 14:34 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-09 14:24:29 PST
<rdar://problem/37405042>
zalan
Comment 2 2018-02-09 14:28:44 PST
Created attachment 333516 [details] Patch
Antti Koivisto
Comment 3 2018-02-09 14:30:57 PST
Comment on attachment 333516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333516&action=review > Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h:46 > + RenderPtr<RenderObject>takeChild(RenderRubyAsBlock& parent, RenderObject& child); Missing space after >
zalan
Comment 4 2018-02-09 14:34:31 PST
Created attachment 333518 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-09 15:22:40 PST
The commit-queue encountered the following flaky tests while processing attachment 333518 [details]: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html bug 182270 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-02-09 15:23:07 PST
Comment on attachment 333518 [details] Patch Clearing flags on attachment: 333518 Committed r228339: <https://trac.webkit.org/changeset/228339>
WebKit Commit Bot
Comment 7 2018-02-09 15:23:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.