Created attachment 323447 [details] ROLLOUT of r223113 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.

Comment on attachment 323447 [details] ROLLOUT of r223113 Clearing flags on attachment: 323447 Committed r223202: <https://trac.webkit.org/changeset/223202>

All reviewed patches have been landed. Closing bug.

Was this initiated because of Kraken or because of Kraken and other bernchmarks?

<rdar://problem/34939565>

(In reply to Filip Pizlo from comment #4) > Was this initiated because of Kraken or because of Kraken and other > bernchmarks? When this patch got landed, 20% Kraken regression came up back on bots, and at the same time, we also observed Speedometer on iOS to regress by 2-4%. We've confirmed Speedometer to progress by the same amount when the initial patch got rolled out and regress again when the patch got re-landed.

(In reply to Ryosuke Niwa from comment #6) > (In reply to Filip Pizlo from comment #4) > > Was this initiated because of Kraken or because of Kraken and other > > bernchmarks? > > When this patch got landed, 20% Kraken regression came up back on bots, You mean one bot. > and > at the same time, we also observed Speedometer on iOS to regress by 2-4%. > We've confirmed Speedometer to progress by the same amount when the initial > patch got rolled out and regress again when the patch got re-landed. Kraken is not really a big focus, and it's not correct to say that we have a 20% regression without precisely qualifying that in fact, most iOS devices see no regression from that change. I hope you agree with me that if you tell someone that something is X% regressed when in reality it is only X% regressed on one device and 0% regressed everywhere else, that this creates an unnecessary sense of urgency. On the other hand, I agree with you the Speedometer is important and if it's true that all Speedo bots saw 2-4% regressions, then we should roll this out. But if Speedometer is like Kraken in the sense that some bots see this and some don't then I'm not sure that an immediate rollout is super productive.

(In reply to Filip Pizlo from comment #7) > (In reply to Ryosuke Niwa from comment #6) > > (In reply to Filip Pizlo from comment #4) > > > Was this initiated because of Kraken or because of Kraken and other > > > bernchmarks? > > > > When this patch got landed, 20% Kraken regression came up back on bots, > > You mean one bot. > > > and > > at the same time, we also observed Speedometer on iOS to regress by 2-4%. > > We've confirmed Speedometer to progress by the same amount when the initial > > patch got rolled out and regress again when the patch got re-landed. > > Kraken is not really a big focus, and it's not correct to say that we have a > 20% regression without precisely qualifying that in fact, most iOS devices > see no regression from that change. I hope you agree with me that if you > tell someone that something is X% regressed when in reality it is only X% > regressed on one device and 0% regressed everywhere else, that this creates > an unnecessary sense of urgency. Right, I agree with you there. > On the other hand, I agree with you the Speedometer is important and if it's > true that all Speedo bots saw 2-4% regressions, then we should roll this out. > > But if Speedometer is like Kraken in the sense that some bots see this and > some don't then I'm not sure that an immediate rollout is super productive. We saw on multiple bots. I'll send you links by an email.

(In reply to Ryosuke Niwa from comment #8) > (In reply to Filip Pizlo from comment #7) > > (In reply to Ryosuke Niwa from comment #6) > > > (In reply to Filip Pizlo from comment #4) > > > > Was this initiated because of Kraken or because of Kraken and other > > > > bernchmarks? > > > > > > When this patch got landed, 20% Kraken regression came up back on bots, > > > > You mean one bot. > > > > > and > > > at the same time, we also observed Speedometer on iOS to regress by 2-4%. > > > We've confirmed Speedometer to progress by the same amount when the initial > > > patch got rolled out and regress again when the patch got re-landed. > > > > Kraken is not really a big focus, and it's not correct to say that we have a > > 20% regression without precisely qualifying that in fact, most iOS devices > > see no regression from that change. I hope you agree with me that if you > > tell someone that something is X% regressed when in reality it is only X% > > regressed on one device and 0% regressed everywhere else, that this creates > > an unnecessary sense of urgency. > > Right, I agree with you there. > > > On the other hand, I agree with you the Speedometer is important and if it's > > true that all Speedo bots saw 2-4% regressions, then we should roll this out. > > > > But if Speedometer is like Kraken in the sense that some bots see this and > > some don't then I'm not sure that an immediate rollout is super productive. > > We saw on multiple bots. I'll send you links by an email. We discussed over e-mail. I'm going to roll this back in.