Created attachment 320211 [details] Patch Warning: includes rebaselines, 12MB patch

it seems the review tool has a hard time dealing with such big patch.. I will re-upload it without the rebaselines for easier review. Will land it with the rebaselines after its reviewed.

Created attachment 320215 [details] Patch

Created attachment 320219 [details] Patch Patch for landing

Comment on attachment 320219 [details] Patch Rejecting attachment 320219 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320219, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit 4bceb41..971b077 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 221773 = 4bceb41e1de8161c00131b6eb893d574f7906140 r221774 = 971b077c7b45edae31264fd3cb06780201d1565e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4482412

Created attachment 320251 [details] Patch Patch for landing, second try

Comment on attachment 320251 [details] Patch Rejecting attachment 320251 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320251, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: M Tools Current branch master is up to date. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/4485487

Created attachment 320431 [details] Patch Patch for landing, third try

Landed in r221858: <http://trac.webkit.org/changeset/221858>

Comment on attachment 320431 [details] Patch Rejecting attachment 320431 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320431, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 588, in read return self._read_chunked(amt) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 648, in _read_chunked value.append(self._safe_read(amt)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 705, in _safe_read raise IncompleteRead(''.join(s), amt) httplib.IncompleteRead: IncompleteRead(0 bytes read, 1024 more expected) Full output: http://webkit-queues.webkit.org/results/4513175