RESOLVED FIXED 175214
Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 2]. 
https://bugs.webkit.org/show_bug.cgi?id=175214
Summary Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 2].
Mark Lam
Reported 2017-08-04 15:07:29 PDT
Actually move the 64-bit and common DFGOSRExit code (previously in DFGOSRExitCompiler) into DFGOSRExit.cpp, and delete unneeded files.
Attachments
proposed patch. (105.30 KB, patch)
2017-08-04 16:51 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (105.38 KB, patch)
2017-08-04 16:52 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch: fixed style issue. (105.55 KB, patch)
2017-08-04 16:59 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-04 15:08:17 PDT
<rdar://problem/33733302>
Radar WebKit Bug Importer
Comment 2 2017-08-04 15:08:19 PDT
<rdar://problem/33733308>
Mark Lam
Comment 3 2017-08-04 16:51:02 PDT
Created attachment 317312 [details] proposed patch.
Build Bot
Comment 4 2017-08-04 16:51:59 PDT
Attachment 317312 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOSRExit32_64.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 5 2017-08-04 16:52:57 PDT
Created attachment 317313 [details] proposed patch.
Build Bot
Comment 6 2017-08-04 16:54:51 PDT
Attachment 317313 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOSRExit32_64.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 7 2017-08-04 16:59:24 PDT
Created attachment 317315 [details] proposed patch: fixed style issue.
Michael Saboff
Comment 8 2017-08-04 17:02:07 PDT
Comment on attachment 317315 [details] proposed patch: fixed style issue. rs=me
Mark Lam
Comment 9 2017-08-04 17:05:24 PDT
Thanks for the review. Landed in r220306: <http://trac.webkit.org/r220306>.
Note You need to log in before you can comment on or make changes to this bug.