RESOLVED FIXED 174091
[GCrypt] Gather crypto constants in a single location 
https://bugs.webkit.org/show_bug.cgi?id=174091
Summary [GCrypt] Gather crypto constants in a single location
Zan Dobersek
Reported 2017-07-03 00:43:16 PDT
Object identifier strings, EC curve names and attributes, as well as other constants used in libgcrypt-based Web Crypto implementation, should be gathered in a single location.
Attachments
WIP patch (16.79 KB, patch)
2017-07-13 04:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (20.13 KB, patch)
2017-07-15 04:01 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (950.08 KB, application/zip)
2017-07-15 05:30 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.82 MB, application/zip)
2017-07-15 06:03 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-07-13 04:32:52 PDT
Created attachment 315342 [details] WIP patch
Zan Dobersek
Comment 2 2017-07-15 04:01:57 PDT
Created attachment 315540 [details] Patch
Build Bot
Comment 3 2017-07-15 05:30:17 PDT
Comment on attachment 315540 [details] Patch Attachment 315540 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4125114 New failing tests: http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html
Build Bot
Comment 4 2017-07-15 05:30:18 PDT
Created attachment 315541 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Build Bot
Comment 5 2017-07-15 06:03:44 PDT
Comment on attachment 315540 [details] Patch Attachment 315540 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4125249 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Build Bot
Comment 6 2017-07-15 06:03:45 PDT
Created attachment 315542 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Michael Catanzaro
Comment 7 2017-07-15 08:02:37 PDT
Comment on attachment 315540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315540&action=review > Source/WebCore/crypto/gcrypt/GCryptUtilities.h:40 > +static const std::array<uint8_t, 18> s_ecPublicKeyIdentifier { { "1.2.840.10045.2.1" } }; For what it's worth, I don't like the s_ style. But of course you should use it if the surrounding code does....
Jiewen Tan
Comment 8 2017-07-31 12:10:45 PDT
Comment on attachment 315540 [details] Patch Looks good to me. r=me.
Zan Dobersek
Comment 9 2017-08-01 04:49:53 PDT
Comment on attachment 315540 [details] Patch Clearing flags on attachment: 315540 Committed r220092: <http://trac.webkit.org/changeset/220092>
Zan Dobersek
Comment 10 2017-08-01 04:49:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-08-01 05:28:27 PDT
<rdar://problem/33652130>
Note You need to log in before you can comment on or make changes to this bug.