172825 – [Mac] Include frames in the scrolling tree when ScrollingTreeIncludesFrames=true

RESOLVED FIXED 172825

[Mac] Include frames in the scrolling tree when ScrollingTreeIncludesFrames=true

https://bugs.webkit.org/show_bug.cgi?id=172825

Summary [Mac] Include frames in the scrolling tree when ScrollingTreeIncludesFrames=true

Frédéric Wang (:fredw)

Reported 2017-06-01 11:07:58 PDT

Attempt to extract this from bug 171667

Attachments
Patch (WIP) (2.87 KB, patch) 2017-06-01 11:08 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (989.69 KB, application/zip) 2017-06-01 12:53 PDT, Build Bot	no flags	Details
Patch (172851 + 172825) (15.24 KB, patch) 2017-06-02 06:15 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1013.60 KB, application/zip) 2017-06-02 07:13 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.73 MB, application/zip) 2017-06-02 07:34 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (10.15 MB, application/zip) 2017-06-02 07:44 PDT, Build Bot	no flags	Details
Patch (11.49 KB, patch) 2017-06-02 07:57 PDT, Frédéric Wang (:fredw)	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.06 MB, application/zip) 2017-06-02 09:02 PDT, Build Bot	no flags	Details
Patch (10.34 KB, patch) 2017-06-02 11:50 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-06-01 11:08:29 PDT

Created attachment 311729 [details] Patch (WIP)

Build Bot

Comment 2 2017-06-01 12:53:47 PDT

Comment on attachment 311729 [details] Patch (WIP) Attachment 311729 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3855104 New failing tests: compositing/iframes/scrolling-iframe.html

Build Bot

Comment 3 2017-06-01 12:53:48 PDT

Created attachment 311742 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Frédéric Wang (:fredw)

Comment 4 2017-06-02 06:15:23 PDT

Created attachment 311819 [details] Patch (172851 + 172825)

Build Bot

Comment 5 2017-06-02 07:13:18 PDT

Comment on attachment 311819 [details] Patch (172851 + 172825) Attachment 311819 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3859695 New failing tests: fast/scrolling/scrolling-tree-includes-frame.html

Build Bot

Comment 6 2017-06-02 07:13:19 PDT

Created attachment 311820 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-06-02 07:34:50 PDT

Comment on attachment 311819 [details] Patch (172851 + 172825) Attachment 311819 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3859713 New failing tests: fast/scrolling/scrolling-tree-includes-frame.html

Build Bot

Comment 8 2017-06-02 07:34:52 PDT

Created attachment 311821 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-06-02 07:44:48 PDT

Comment on attachment 311819 [details] Patch (172851 + 172825) Attachment 311819 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3859722 New failing tests: compositing/iframes/scrolling-iframe.html

Build Bot

Comment 10 2017-06-02 07:44:50 PDT

Created attachment 311824 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Frédéric Wang (:fredw)

Comment 11 2017-06-02 07:57:59 PDT

Created attachment 311825 [details] Patch Simon: I'm not yet 100% sure of this on all these platforms and the patch applies on bug 172851 anyway, but I'm asking review to get some feedback.

Build Bot

Comment 12 2017-06-02 09:02:08 PDT

Comment on attachment 311825 [details] Patch Attachment 311825 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3860071 New failing tests: fast/scrolling/scrolling-tree-includes-frame.html

Build Bot

Comment 13 2017-06-02 09:02:10 PDT

Created attachment 311829 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Frédéric Wang (:fredw)

Comment 14 2017-06-02 11:50:10 PDT

Created attachment 311842 [details] Patch Same patch, but try again after r217726.

Frédéric Wang (:fredw)

Comment 15 2017-06-02 12:40:14 PDT

Committed r217730: <http://trac.webkit.org/changeset/217730>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Frames

Assignee

Frédéric Wang (:fredw)

Reported

2017-06-01 11:07 PDT

Modified

2017-06-02 12:40 PDT History

CC List

4 users Show

URL

Keywords

Depends on

172851

Blocks

171667

Dependencies

tree graph