WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167829
Rename AnimationController to CSSAnimationController
https://bugs.webkit.org/show_bug.cgi?id=167829
Summary
Rename AnimationController to CSSAnimationController
Said Abou-Hallawa
Reported
2017-02-03 20:58:26 PST
AnimationController is a very generic name. The current function of this class is CSS animation.
Attachments
Patch
(113.72 KB, patch)
2017-02-03 21:13 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(116.36 KB, patch)
2017-02-04 01:24 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(116.95 KB, patch)
2017-02-04 01:36 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(118.21 KB, patch)
2017-02-06 09:26 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
(1.13 MB, application/zip)
2017-02-06 10:21 PST
,
Build Bot
no flags
Details
Patch
(118.21 KB, patch)
2017-02-06 10:25 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-02-03 20:59:41 PST
<
rdar://problem/30361923
>
Said Abou-Hallawa
Comment 2
2017-02-03 21:13:46 PST
Created
attachment 300602
[details]
Patch
Said Abou-Hallawa
Comment 3
2017-02-04 01:24:10 PST
Created
attachment 300608
[details]
Patch
WebKit Commit Bot
Comment 4
2017-02-04 01:26:02 PST
Attachment 300608
[details]
did not pass style-queue: ERROR: Source/WebCore/history/CachedFrame.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Said Abou-Hallawa
Comment 5
2017-02-04 01:36:51 PST
Created
attachment 300610
[details]
Patch
WebKit Commit Bot
Comment 6
2017-02-04 01:38:52 PST
Attachment 300610
[details]
did not pass style-queue: ERROR: Source/WebCore/history/CachedFrame.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Said Abou-Hallawa
Comment 7
2017-02-06 09:26:30 PST
Created
attachment 300728
[details]
Patch
Build Bot
Comment 8
2017-02-06 10:21:49 PST
Comment on
attachment 300728
[details]
Patch
Attachment 300728
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/3014398
New failing tests: fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html
Build Bot
Comment 9
2017-02-06 10:21:52 PST
Created
attachment 300732
[details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Said Abou-Hallawa
Comment 10
2017-02-06 10:25:29 PST
Created
attachment 300733
[details]
Patch
WebKit Commit Bot
Comment 11
2017-02-06 11:23:16 PST
Comment on
attachment 300733
[details]
Patch Clearing flags on attachment: 300733 Committed
r211741
: <
http://trac.webkit.org/changeset/211741
>
WebKit Commit Bot
Comment 12
2017-02-06 11:23:21 PST
All reviewed patches have been landed. Closing bug.
Antoine Quint
Comment 13
2017-02-10 02:04:52 PST
***
Bug 123227
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug