WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167155
Fix the JSCOnly build after
r210844
https://bugs.webkit.org/show_bug.cgi?id=167155
Summary
Fix the JSCOnly build after r210844
Csaba Osztrogonác
Reported
2017-01-18 01:02:56 PST
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/heap/EdenGCActivityCallback.cpp.o: In function `JSC::EdenGCActivityCallback::EdenGCActivityCallback(JSC::Heap*)': EdenGCActivityCallback.cpp:(.text+0x40): undefined reference to `JSC::Heap::vm() const' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. It seems HeapInlines.h should be included in EdenGCActivityCallback.cpp too, fix is coming soon.
Attachments
Patch
(1.07 KB, patch)
2017-01-18 01:04 PST
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2017-01-18 01:04:31 PST
Created
attachment 299122
[details]
Patch patch for EWS, will land after all of them are green
WebKit Commit Bot
Comment 2
2017-01-18 02:26:00 PST
Comment on
attachment 299122
[details]
Patch Clearing flags on attachment: 299122 Committed
r210849
: <
http://trac.webkit.org/changeset/210849
>
WebKit Commit Bot
Comment 3
2017-01-18 02:26:04 PST
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 4
2017-01-18 04:17:52 PST
Nice!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug