RESOLVED FIXED 165969
CellState should have members with accurate names 
https://bugs.webkit.org/show_bug.cgi?id=165969
Summary CellState should have members with accurate names
Filip Pizlo
Reported 2016-12-16 14:02:16 PST
I keep having to rename members in CellState because understanding their meaning is so hard.
Attachments
the patch (8.51 KB, patch)
2016-12-16 14:07 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-12-16 14:07:55 PST
Created attachment 297354 [details] the patch
Mark Lam
Comment 2 2016-12-16 14:13:23 PST
Comment on attachment 297354 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=297354&action=review r=me with typo fix. > Source/JavaScriptCore/heap/CellState.h:34 > + // is a full collection and it's actually a while object (you'd know because its mark bit /while/white/?
Filip Pizlo
Comment 3 2016-12-16 18:40:11 PST
(In reply to comment #2) > Comment on attachment 297354 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297354&action=review > > r=me with typo fix. > > > Source/JavaScriptCore/heap/CellState.h:34 > > + // is a full collection and it's actually a while object (you'd know because its mark bit > > /while/white/? Yup, fixed!
Filip Pizlo
Comment 4 2016-12-16 18:42:04 PST
Landed in https://trac.webkit.org/changeset/209954
Note You need to log in before you can comment on or make changes to this bug.