RESOLVED FIXED 165785
[Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate 
https://bugs.webkit.org/show_bug.cgi?id=165785
Summary [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
Andy Estes
Reported 2016-12-12 17:11:09 PST
[Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
Attachments
Patch (15.06 KB, patch)
2016-12-12 17:37 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (14.97 KB, patch)
2016-12-12 17:48 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2016-12-13 11:30 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2016-12-12 17:37:03 PST
Created attachment 296973 [details] Patch
Andy Estes
Comment 2 2016-12-12 17:37:53 PST
rdar://problem/26929398
WebKit Commit Bot
Comment 3 2016-12-12 17:39:17 PST
Attachment 296973 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:589: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:640: Missing spaces around : [whitespace/init] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 4 2016-12-12 17:48:19 PST
Created attachment 296974 [details] Patch
WebKit Commit Bot
Comment 5 2016-12-12 17:50:08 PST
Attachment 296974 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:590: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:641: Missing spaces around : [whitespace/init] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 6 2016-12-12 20:22:04 PST
Comment on attachment 296974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296974&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:605 > + WKEditorInsertAction wkAction; > + switch (action) { > + case EditorInsertActionTyped: > + wkAction = WKEditorInsertActionTyped; > + break; > + case EditorInsertActionPasted: > + wkAction = WKEditorInsertActionPasted; > + break; > + case EditorInsertActionDropped: > + wkAction = WKEditorInsertActionDropped; > + break; > + } Would like this mapping to be a separate helper function.
Andy Estes
Comment 7 2016-12-13 11:30:49 PST
Created attachment 297027 [details] Patch
WebKit Commit Bot
Comment 8 2016-12-13 14:09:23 PST
Comment on attachment 297027 [details] Patch Clearing flags on attachment: 297027 Committed r209775: <http://trac.webkit.org/changeset/209775>
WebKit Commit Bot
Comment 9 2016-12-13 14:09:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.