RESOLVED FIXED 164747
Update SubtleCrypto::unwrapKey to match the latest spec 
https://bugs.webkit.org/show_bug.cgi?id=164747
Summary Update SubtleCrypto::unwrapKey to match the latest spec
Jiewen Tan
Reported 2016-11-14 16:01:18 PST
Update SubtleCrypto::unwrapKey to match the latest spec.
Attachments
Patch (67.07 KB, patch)
2016-11-30 17:41 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (67.04 KB, patch)
2016-12-01 12:22 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-11-14 16:54:00 PST
<rdar://problem/29258198>
Jiewen Tan
Comment 2 2016-11-30 17:41:06 PST
Created attachment 295801 [details] Patch
WebKit Commit Bot
Comment 3 2016-11-30 17:44:06 PST
Attachment 295801 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:170: CryptoAlgorithmAES_KW::unwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:41: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:52: unwrapKeyAES_KW is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:78: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jiewen Tan
Comment 4 2016-12-01 12:22:00 PST
Created attachment 295875 [details] Patch
WebKit Commit Bot
Comment 5 2016-12-01 12:24:56 PST
Attachment 295875 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:170: CryptoAlgorithmAES_KW::unwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:41: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:52: unwrapKeyAES_KW is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:78: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 6 2016-12-01 12:35:50 PST
Comment on attachment 295875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295875&action=review Looks good! > Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:940 > + // The following operation should be performed asynchronously. Is this a note to remind you to do something in the future?
Jiewen Tan
Comment 7 2016-12-01 12:38:29 PST
Comment on attachment 295875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295875&action=review Thanks Brent for r+ my patch. >> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:940 >> + // The following operation should be performed asynchronously. > > Is this a note to remind you to do something in the future? Not really. It is a note to remind me of whether the following operation will be executed asynchronously/synchronously.
WebKit Commit Bot
Comment 8 2016-12-01 13:45:52 PST
Comment on attachment 295875 [details] Patch Clearing flags on attachment: 295875 Committed r209200: <http://trac.webkit.org/changeset/209200>
WebKit Commit Bot
Comment 9 2016-12-01 13:45:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.