<rdar://problem/29257935>

Created attachment 295675 [details] Patch

Attachment 295675 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:80: CryptoAlgorithmRSASSA_PKCS1_v1_5::verify is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:87: verifyRSASSA_PKCS1_v1_5 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:133: CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp:43: CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 57 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 295675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295675&action=review Nice job! > Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp:113 > +void CryptoAlgorithmHMAC::platformVerify(Ref<CryptoKey>&& key, Vector<uint8_t>&& signature, Vector<uint8_t>&& data, BoolCallback&& callback, ExceptionCallback&& exceptionCallback, ScriptExecutionContext& context, WorkQueue& workQueue) We should probably rename this directory from "mac" to "cocoa" or "apple" or something, since it is used on all Apple platforms. > LayoutTests/imported/w3c/WebCryptoAPI/idlharness-expected.txt:53 > +PASS SubtleCrypto interface: calling verify(AlgorithmIdentifier,CryptoKey,BufferSource,BufferSource) on crypto.subtle with too few arguments must throw TypeError Yay!

Comment on attachment 295675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295675&action=review Thanks Brent for r+ my patch. >> Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp:113 >> +void CryptoAlgorithmHMAC::platformVerify(Ref<CryptoKey>&& key, Vector<uint8_t>&& signature, Vector<uint8_t>&& data, BoolCallback&& callback, ExceptionCallback&& exceptionCallback, ScriptExecutionContext& context, WorkQueue& workQueue) > > We should probably rename this directory from "mac" to "cocoa" or "apple" or something, since it is used on all Apple platforms. That actually confuses me as well. We have a lot files having suffix Mac but not only being used in Mac. I mean besides crypto.

Comment on attachment 295675 [details] Patch Clearing flags on attachment: 295675 Committed r209150: <http://trac.webkit.org/changeset/209150>

All reviewed patches have been landed. Closing bug.