RESOLVED FIXED163213
Support InputEvent.dataTransfer for the InputEvent spec 
https://bugs.webkit.org/show_bug.cgi?id=163213
Summary Support InputEvent.dataTransfer for the InputEvent spec
Wenson Hsieh
Reported 2016-10-10 07:41:52 PDT
Support InputEvent.dataTransfer for the InputEvent spec
Attachments
Patch (53.14 KB, patch)
2016-10-23 17:32 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.36 MB, application/zip)
2016-10-23 18:35 PDT, Build Bot 		no flags
Details
Test patch (53.64 KB, patch)
2016-10-23 22:46 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Test patch (53.90 KB, patch)
2016-10-24 07:36 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix EFL/GTK builds. (53.91 KB, patch)
2016-10-24 08:10 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix EFL/GTK builds. (54.66 KB, patch)
2016-10-24 08:26 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Attempt to fix EFL/GTK builds (56.21 KB, patch)
2016-10-24 09:26 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Add ChangeLog entries. (60.43 KB, patch)
2016-10-24 10:26 PDT, Wenson Hsieh 		rniwa: review+
DetailsFormatted DiffDiff
Attempt to fix GTK build (60.84 KB, patch)
2016-10-25 11:56 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.84 KB, patch)
2016-10-25 12:04 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2016-10-10 13:26:05 PDT
<rdar://problem/28700407>
Wenson Hsieh
Comment 2 2016-10-23 17:32:57 PDT
Created attachment 292567 [details] Patch
Build Bot
Comment 3 2016-10-23 18:35:17 PDT
Comment on attachment 292567 [details] Patch Attachment 292567 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2354019 New failing tests: fast/events/input-events-fired-when-typing.html editing/pasteboard/paste-head-contents.html
Build Bot
Comment 4 2016-10-23 18:35:20 PDT
Created attachment 292570 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Wenson Hsieh
Comment 5 2016-10-23 22:46:28 PDT
Created attachment 292582 [details] Test patch
Wenson Hsieh
Comment 6 2016-10-24 07:36:59 PDT
Created attachment 292608 [details] Test patch
Wenson Hsieh
Comment 7 2016-10-24 08:10:15 PDT
Created attachment 292612 [details] Fix EFL/GTK builds.
Wenson Hsieh
Comment 8 2016-10-24 08:26:00 PDT
Created attachment 292613 [details] Fix EFL/GTK builds.
Wenson Hsieh
Comment 9 2016-10-24 09:26:54 PDT
Created attachment 292617 [details] Attempt to fix EFL/GTK builds
Wenson Hsieh
Comment 10 2016-10-24 10:26:16 PDT
Created attachment 292622 [details] Add ChangeLog entries.
Ryosuke Niwa
Comment 11 2016-10-25 11:43:15 PDT
Comment on attachment 292622 [details] Add ChangeLog entries. It looks like GTK+ is complaining that it can't find the symbol for Pasteboard::Pasteboard. Please fix that before landing it.
Wenson Hsieh
Comment 12 2016-10-25 11:56:57 PDT
Created attachment 292794 [details] Attempt to fix GTK build
Wenson Hsieh
Comment 13 2016-10-25 12:04:36 PDT
Created attachment 292798 [details] Patch for landing
WebKit Commit Bot
Comment 14 2016-10-25 13:26:01 PDT
Comment on attachment 292798 [details] Patch for landing Clearing flags on attachment: 292798 Committed r207841: <http://trac.webkit.org/changeset/207841>
Michael Catanzaro
Comment 15 2016-10-25 17:03:07 PDT
The test is failing on the GTK+ bot: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-actual.txt @@ -2,7 +2,7 @@ destination after pasting (text/html): | <b> -| style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" +| style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px;" | "LayoutTests" | <i> | "are" That difference is that we have -webkit-tap-highlight-color and not -webkit-text-size-adjust. Is it safe to make that the expected result for GTK+, or is it a real bug?
Wenson Hsieh
Comment 16 2016-10-25 17:07:01 PDT
It seems safe to mark as expected. The key behavior is that the dataTransfer's text/html data contains the HTML styles of the copied text, which might be different for GTK.
Michael Catanzaro
Comment 17 2016-10-26 10:31:22 PDT
Will-do, thanks!
Michael Catanzaro
Comment 18 2016-10-26 11:30:26 PDT
(Landed in r207904.)
Note You need to log in before you can comment on or make changes to this bug.