RESOLVED FIXED161592
[CMake] Duplicated IDL files in WebCore_IDL_FILES 
https://bugs.webkit.org/show_bug.cgi?id=161592
Summary [CMake] Duplicated IDL files in WebCore_IDL_FILES
Fujii Hironori
Reported 2016-09-04 22:27:03 PDT
[CMake] Duplicated IDL files in WebCore_IDL_FILES Some IDL files are listed in WebCore_IDL_FILES doubly. I've found this problem in the experiment of Bug 161433. Ninja issues a lot of warnings. > ninja: warning: multiple rules generate DerivedSources/WebCore/JSANGLEInstancedArrays.cpp. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > ninja: warning: multiple rules generate DerivedSources/WebCore/JSANGLEInstancedArrays.h. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > ninja: warning: multiple rules generate DerivedSources/WebCore/JSEXTBlendMinMax.cpp. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > ninja: warning: multiple rules generate DerivedSources/WebCore/JSEXTBlendMinMax.h. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > ninja: warning: multiple rules generate DerivedSources/WebCore/JSEXTFragDepth.cpp. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > ninja: warning: multiple rules generate DerivedSources/WebCore/JSEXTFragDepth.h. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn] > (...)
Attachments
Patch (3.90 KB, patch)
2016-09-04 22:40 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (4.87 KB, patch)
2016-09-05 01:03 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-09-04 22:40:03 PDT
Created attachment 287929 [details] Patch
Fujii Hironori
Comment 2 2016-09-04 23:25:02 PDT
EWS failed with two problems. mac-debug-ews > FAIL: (JS) JSTestClassWithJSBuiltinConstructor.cpp > --- WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp 2016-08-30 14:19:02.000000000 -0700 > +++ /var/folders/7n/s62c21h54p549lcpn5v012mc0000gn/T/tmpyL67Nh/JSTestClassWithJSBuiltinConstructor.cpp 2016-09-04 22:57:30.000000000 -0700 > @@ -201,7 +201,7 @@ > // by adding the SkipVTableValidation attribute to the interface IDL definition > RELEASE_ASSERT(actualVTablePointer == expectedVTablePointer); > #endif > - return createWrapper<JSTestClassWithJSBuiltinConstructor, TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl)); > + return createWrapper<TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl)); > } > > JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, TestClassWithJSBuiltinConstructor& impl) win-ews > C:\cygwin\home\buildbot\WebKit\Source\WebCore\DerivedSources.cpp(633): fatal error C1083: Cannot open include file: 'JSUserMessageHandler.cpp': No such file or directory
Fujii Hironori
Comment 3 2016-09-05 00:07:27 PDT
(In reply to comment #2) > mac-debug-ews > > > FAIL: (JS) JSTestClassWithJSBuiltinConstructor.cpp Filed as Bug 161595.
Fujii Hironori
Comment 4 2016-09-05 01:03:18 PDT
Created attachment 287940 [details] Patch
Darin Adler
Comment 5 2016-09-05 10:01:03 PDT
Comment on attachment 287940 [details] Patch This is one reason we often sort things alphabetically rather than trying to organize them logically. Makes duplicates much easier to spot.
WebKit Commit Bot
Comment 6 2016-09-05 10:23:30 PDT
Comment on attachment 287940 [details] Patch Clearing flags on attachment: 287940 Committed r205457: <http://trac.webkit.org/changeset/205457>
WebKit Commit Bot
Comment 7 2016-09-05 10:23:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.