RESOLVED FIXED 159432
IDBDatabase can null deref its ScriptExecutionContext inside connectionToServerLost 
https://bugs.webkit.org/show_bug.cgi?id=159432
Summary IDBDatabase can null deref its ScriptExecutionContext inside connectionToServ...
Brady Eidson
Reported 2016-07-05 12:44:01 PDT
IDBDatabase can null deref its ScriptExecutionContext inside connectionToServerLost If an IDBDatabase object is still live when a page navigates, then it loses its ScriptExecutionContext. Then - if before GC happens that would delete the database object - the database process connection is dropped, this callback doesn't do the right thing. I can make it do the right thing, but a targeted test will not be possible.
Attachments
Patch (2.37 KB, patch)
2016-07-05 13:26 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-07-05 12:44:44 PDT
<rdar://problem/27169924>
Brady Eidson
Comment 2 2016-07-05 13:26:14 PDT
Created attachment 282813 [details] Patch
Alex Christensen
Comment 3 2016-07-05 13:33:34 PDT
Comment on attachment 282813 [details] Patch Could we make m_activeTransactions a HashMap to Refs instead of RefPtrs?
Brady Eidson
Comment 4 2016-07-05 13:35:48 PDT
(In reply to comment #3) > Comment on attachment 282813 [details] > Patch > > Could we make m_activeTransactions a HashMap to Refs instead of RefPtrs? Sure, but that's outside the scope of this patch.
Brady Eidson
Comment 5 2016-07-05 14:39:13 PDT
https://trac.webkit.org/changeset/202833
Note You need to log in before you can comment on or make changes to this bug.