RESOLVED FIXED 158620
WebRTC: Add media setup test with complete offer/answer dialog 
https://bugs.webkit.org/show_bug.cgi?id=158620
Summary WebRTC: Add media setup test with complete offer/answer dialog
Adam Bergkvist
Reported 2016-06-10 10:05:55 PDT
Add test that sets up media with a single SDP offer/answer dialog.
Attachments
Proposed patch (9.85 KB, patch)
2016-06-10 10:27 PDT, Adam Bergkvist 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (629.38 KB, application/zip)
2016-06-10 11:33 PDT, Build Bot 		no flags
Details
Updated patch (9.81 KB, patch)
2016-06-13 03:58 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2016-06-10 10:27:28 PDT
Created attachment 281015 [details] Proposed patch
Build Bot
Comment 2 2016-06-10 11:33:43 PDT
Comment on attachment 281015 [details] Proposed patch Attachment 281015 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1479623 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html
Build Bot
Comment 3 2016-06-10 11:33:46 PDT
Created attachment 281020 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Adam Bergkvist
Comment 4 2016-06-13 03:58:54 PDT
Created attachment 281164 [details] Updated patch
Adam Bergkvist
Comment 5 2016-06-13 05:01:13 PDT
Eric, I've tried to apply your review comments from https://bugs.webkit.org/show_bug.cgi?id=158621 to this test as well.
Eric Carlson
Comment 6 2016-06-13 07:55:49 PDT
(In reply to comment #5) > Eric, I've tried to apply your review comments from > https://bugs.webkit.org/show_bug.cgi?id=158621 to this test as well. Thanks Adam!
Adam Bergkvist
Comment 7 2016-06-13 12:14:41 PDT
Comment on attachment 281164 [details] Updated patch Thanks for reviewing!
WebKit Commit Bot
Comment 8 2016-06-13 12:37:01 PDT
Comment on attachment 281164 [details] Updated patch Clearing flags on attachment: 281164 Committed r201998: <http://trac.webkit.org/changeset/201998>
WebKit Commit Bot
Comment 9 2016-06-13 12:37:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.