RESOLVED FIXED 157732
woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable 
https://bugs.webkit.org/show_bug.cgi?id=157732
Summary woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable
Michael Catanzaro
Reported 2016-05-15 17:50:02 PDT
woff2_dec.cc triggers -Wsign-compare
Attachments
Patch (1.17 KB, patch)
2016-05-15 18:07 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-05-15 18:06:16 PDT
It's also triggering -Wunused-but-set-variable Instead of fixing these, let's suppress them, since it's third-party code. We could use a heavy hammer and use -w to suppress all warnings from third-party code, but let's start with suppressing just the problematic ones so we can see if new warnings get introduced in the future.
Michael Catanzaro
Comment 2 2016-05-15 18:07:54 PDT
Created attachment 278987 [details] Patch
WebKit Commit Bot
Comment 3 2016-05-23 18:53:44 PDT
Comment on attachment 278987 [details] Patch Clearing flags on attachment: 278987 Committed r201313: <http://trac.webkit.org/changeset/201313>
WebKit Commit Bot
Comment 4 2016-05-23 18:53:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.