156836 – MathOperator: Add fallback mechanisms for stretching and mirroring radical symbols

RESOLVED FIXED 156836

MathOperator: Add fallback mechanisms for stretching and mirroring radical symbols

https://bugs.webkit.org/show_bug.cgi?id=156836

Summary MathOperator: Add fallback mechanisms for stretching and mirroring radical sy...

Frédéric Wang (:fredw)

Reported 2016-04-21 01:21:50 PDT

This bug will cover: - Drawing of stretched radical using strokePath (as currently done in RenderMathMLRadicalOperator::paint) as a fallback for fonts without a MATH table. - Mirroring of radical symbol in RTL mode (as done by the MathOperator.cpp changes from attachment 276632 [details]) because for now it seems hard to support glyph-level mirroring via the rtlm feature.

Attachments
testcase (542 bytes, text/html) 2016-04-21 05:47 PDT, Frédéric Wang (:fredw)	no flags	Details
WIP Patch (14.10 KB, patch) 2016-04-21 06:33 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch for EWS testing (332.41 KB, patch) 2016-04-21 06:34 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.33 MB, application/zip) 2016-04-21 07:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.54 MB, application/zip) 2016-04-21 07:59 PDT, Build Bot	no flags	Details
Patch for EWS testing (350.74 KB, patch) 2016-04-21 08:24 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (35.68 KB, patch) 2016-04-21 08:47 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch for EWS testing (352.98 KB, patch) 2016-04-21 08:47 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (48.62 KB, patch) 2016-04-26 08:51 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (48.68 KB, patch) 2016-05-09 00:53 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch for EWS testing (365.81 KB, patch) 2016-05-11 02:23 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (824.73 KB, application/zip) 2016-05-11 03:17 PDT, Build Bot	no flags	Details
Patch for EWS testing (419.15 KB, patch) 2016-05-11 03:24 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (101.90 KB, patch) 2016-05-11 03:54 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (101.98 KB, patch) 2016-06-16 21:40 PDT, Frédéric Wang (:fredw)	svillar: review+	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2016-04-21 05:47:27 PDT

Created attachment 276913 [details] testcase

Frédéric Wang (:fredw)

Comment 2 2016-04-21 06:33:31 PDT

Created attachment 276917 [details] WIP Patch

Frédéric Wang (:fredw)

Comment 3 2016-04-21 06:34:52 PDT

Created attachment 276918 [details] Patch for EWS testing

Build Bot

Comment 4 2016-04-21 07:26:59 PDT

Comment on attachment 276918 [details] Patch for EWS testing Attachment 276918 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1196372 New failing tests: mathml/radical-fallback.html

Build Bot

Comment 5 2016-04-21 07:27:02 PDT

Created attachment 276923 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-04-21 07:59:32 PDT

Comment on attachment 276918 [details] Patch for EWS testing Attachment 276918 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1196432 New failing tests: mathml/presentation/inferred-mrow-stretchy.html mathml/radical-fallback.html mathml/presentation/tokenElements-dynamic.html mathml/presentation/direction-overall.html mathml/presentation/inferred-mrow-baseline.html mathml/presentation/phantom.html mathml/presentation/stretchy-depth-height.html mathml/presentation/radical-bar-visibility.html mathml/wbr-in-mroot-crash.html mathml/presentation/menclose-notation-radical.html

Build Bot

Comment 7 2016-04-21 07:59:35 PDT

Created attachment 276926 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Frédéric Wang (:fredw)

Comment 8 2016-04-21 08:24:00 PDT

Created attachment 276927 [details] Patch for EWS testing

Frédéric Wang (:fredw)

Comment 9 2016-04-21 08:47:22 PDT

Created attachment 276930 [details] Patch

Frédéric Wang (:fredw)

Comment 10 2016-04-21 08:47:42 PDT

Created attachment 276931 [details] Patch for EWS testing

Frédéric Wang (:fredw)

Comment 11 2016-04-26 08:51:10 PDT

Created attachment 277374 [details] Patch

Frédéric Wang (:fredw)

Comment 12 2016-05-09 00:53:02 PDT

Created attachment 278394 [details] Patch Updating after https://trac.webkit.org/changeset/200569

Frédéric Wang (:fredw)

Comment 13 2016-05-10 06:07:14 PDT

Comment on attachment 278394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278394&action=review > Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h:39 > + extra whitespace here

Frédéric Wang (:fredw)

Comment 14 2016-05-11 02:23:17 PDT

Created attachment 278608 [details] Patch for EWS testing

Build Bot

Comment 15 2016-05-11 03:17:26 PDT

Comment on attachment 278608 [details] Patch for EWS testing Attachment 278608 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1302950 New failing tests: mathml/radical-fallback.html mathml/presentation/roots.xhtml

Build Bot

Comment 16 2016-05-11 03:17:30 PDT

Created attachment 278612 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Frédéric Wang (:fredw)

Comment 17 2016-05-11 03:24:26 PDT

Created attachment 278613 [details] Patch for EWS testing

Frédéric Wang (:fredw)

Comment 18 2016-05-11 03:54:15 PDT

Created attachment 278614 [details] Patch

Frédéric Wang (:fredw)

Comment 19 2016-06-16 21:40:22 PDT

Created attachment 281530 [details] Patch

Sergio Villar Senin

Comment 20 2016-06-17 01:25:19 PDT

Comment on attachment 281530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281530&action=review > Source/WebCore/ChangeLog:7 > + We need a description of the whole patch here _and_ a rationale for the change. > Source/WebCore/rendering/mathml/MathOperator.cpp:359 > + m_radicalVerticalScale = static_cast<float>(targetSize) / height; targetSize.toFloat()

Frédéric Wang (:fredw)

Comment 21 2016-06-17 02:24:59 PDT

Committed r202161: <http://trac.webkit.org/changeset/202161>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component MathML

Assignee

Frédéric Wang (:fredw)

Reported

2016-04-21 01:21 PDT

Modified

2016-06-17 07:55 PDT History

CC List

13 users Show

URL

Keywords

Depends on

152244

Blocks

153987 157519

Dependencies

tree graph