WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156578
[css-grid] Implement CSSGridTemplateAreasValue::equals
https://bugs.webkit.org/show_bug.cgi?id=156578
Summary
[css-grid] Implement CSSGridTemplateAreasValue::equals
Manuel Rego Casasnovas
Reported
Thursday, April 14, 2016 2:16:00 PM UTC
[css-grid] Implement CSSGridTemplateAreasValue::equals
Attachments
Patch
(4.39 KB, patch)
2016-04-14 06:16 PDT
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1
Thursday, April 14, 2016 2:16:57 PM UTC
Created
attachment 276394
[details]
Patch
Manuel Rego Casasnovas
Comment 2
Thursday, April 14, 2016 2:18:32 PM UTC
There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
Manuel Rego Casasnovas
Comment 3
Thursday, April 14, 2016 2:18:52 PM UTC
There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
WebKit Commit Bot
Comment 4
Thursday, April 14, 2016 9:49:03 PM UTC
Comment on
attachment 276394
[details]
Patch Clearing flags on attachment: 276394 Committed
r199551
: <
http://trac.webkit.org/changeset/199551
>
WebKit Commit Bot
Comment 5
Thursday, April 14, 2016 9:49:06 PM UTC
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug