NEW 154590
[css-grid][css-flex] Make OrderIterator a STL iterator class 
https://bugs.webkit.org/show_bug.cgi?id=154590
Summary [css-grid][css-flex] Make OrderIterator a STL iterator class
Manuel Rego Casasnovas
Reported 2016-02-23 09:29:26 PST
OrderIterator is used by Grid Layout and Flexbox. From a comment in bug #154336 it would be nice to make it a STL iterator class: > > Source/WebCore/rendering/RenderGrid.cpp:1184 > > + for (RenderBox* child = m_orderIterator.first(); child; child = m_orderIterator.next()) { > > Perhaps not for this patch but we should make OrderIterator a stl > iterator-like class so that instead of first() and next() we have begin() > and end() and we could do things like > > for (auto child : m_orderIterator)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-20 11:04:15 PDT
<rdar://problem/134356478>
Nathan Solomon
Comment 2 2024-08-20 11:57:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32474
Nathan Solomon
Comment 3 2024-08-20 12:14:06 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32475
Note You need to log in before you can comment on or make changes to this bug.