Created attachment 271445 [details] Patch v1

Attachment 271445 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebKit2/WebProcess/Databases/WebDatabaseProvider.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h:60: The parameter name "sessionID" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 271445 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=271445&action=review r=me > Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h:76 > + HashMap<uint64_t, RefPtr<WebIDBConnectionToClient>> m_webIDBConnections; It might be nice to typedef uint64_t ServerConnectionIdentifer. There are a lot of uint64_t's in IDB. > Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:62 > + return *m_connectionToClient; It would be nice if you could make m_connectionToClient a ref. Does it need to be initialized after relaxAdoptionRequirement? > Source/WebKit2/WebProcess/Databases/WebDatabaseProvider.h:30 > +#include <WebCore/InProcessIDBServer.h> > #include <WebCore/DatabaseProvider.h> Include order > Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h:60 > + WebIDBConnectionToServer& idbConnectionToServerForSession(const WebCore::SessionID& sessionID); Parameter name should be removed.

(In reply to comment #3) > Comment on attachment 271445 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271445&action=review > > r=me > > > Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h:76 > > + HashMap<uint64_t, RefPtr<WebIDBConnectionToClient>> m_webIDBConnections; > > It might be nice to typedef uint64_t ServerConnectionIdentifer. There are a > lot of uint64_t's in IDB. Unclear to me why a whole bunch of compatible typedefs would be better :( > > > Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:62 > > + return *m_connectionToClient; > > It would be nice if you could make m_connectionToClient a ref. Can't. > Does it need to be initialized after relaxAdoptionRequirement? Yes > > > Source/WebKit2/WebProcess/Databases/WebDatabaseProvider.h:30 > > +#include <WebCore/InProcessIDBServer.h> > > #include <WebCore/DatabaseProvider.h> > > Include order Whoops! > > > Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h:60 > > + WebIDBConnectionToServer& idbConnectionToServerForSession(const WebCore::SessionID& sessionID); > > Parameter name should be removed. Sure!

gtk and elf are broken apparently because some headers from WebCore cannot be found... I don't know how to fix!

NM, figured out it out in the WebKit2 CMakeLists.txt

Created attachment 271460 [details] Patch for landing

Comment on attachment 271460 [details] Patch for landing Clearing flags on attachment: 271460 Committed r196651: <http://trac.webkit.org/changeset/196651>

All reviewed patches have been landed. Closing bug.

(In reply to comment #8) > Comment on attachment 271460 [details] > Patch for landing > > Clearing flags on attachment: 271460 > > Committed r196651: <http://trac.webkit.org/changeset/196651> It broke the Apple Mac cmake build.