WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
153999
check-webkit-style cannot check parameters with macros
https://bugs.webkit.org/show_bug.cgi?id=153999
Summary
check-webkit-style cannot check parameters with macros
Jiewen Tan
Reported
2016-02-08 12:06:05 PST
For a method defined as below: MouseEvent::MouseEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView* view, int detail, int screenX, int screenY, int clientX, int clientY, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button, PassRefPtr<EventTarget> relatedTarget) : MouseRelatedEvent(eventType, canBubble, cancelable, WTF::currentTime(), view, detail, IntPoint(screenX, screenY), IntPoint(0, 0), //L135 #if ENABLE(POINTER_LOCK) IntPoint(0, 0), //L137 #endif ctrlKey, altKey, shiftKey, metaKey, false) , m_button(button == (unsigned short)-1 ? 0 : button) , m_buttonDown(button != (unsigned short)-1) , m_relatedTarget(relatedTarget) { initCoordinates(IntPoint(clientX, clientY)); } check-webkit-style will complains: ERROR: Source/WebCore/dom/MouseEvent.cpp:135: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:137: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Refer to
Bug 153903
.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2016-02-09 22:29:09 PST
***
Bug 153998
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug