WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153546
Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
https://bugs.webkit.org/show_bug.cgi?id=153546
Summary
Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
Filip Pizlo
Reported
2016-01-27 09:07:30 PST
Patch forthcoming.
Attachments
the patch
(2.46 KB, patch)
2016-01-27 09:10 PST
,
Filip Pizlo
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2016-01-27 09:10:39 PST
Created
attachment 270001
[details]
the patch
Saam Barati
Comment 2
2016-01-27 11:01:13 PST
Comment on
attachment 270001
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=270001&action=review
r=me
> Source/JavaScriptCore/b3/air/AirTmpWidth.cpp:142 > + // We already ensures that both tmps are added to the width map. That's important
I don't think this comment is needed given the above. If you think we need is, "ensures" => "ensure"
Filip Pizlo
Comment 3
2016-01-27 12:11:21 PST
Landed in
http://trac.webkit.org/changeset/195683
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug