WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153359
Modern IDB: Add transactions and create/delete object store to SQLite backend
https://bugs.webkit.org/show_bug.cgi?id=153359
Summary
Modern IDB: Add transactions and create/delete object store to SQLite backend
Brady Eidson
Reported
2016-01-22 10:33:13 PST
Modern IDB: Add transactions and create/delete object store to SQLite backend
Attachments
Patch v1
(47.48 KB, patch)
2016-01-22 10:47 PST
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch v2
(47.52 KB, patch)
2016-01-22 11:22 PST
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2016-01-22 10:47:29 PST
Created
attachment 269581
[details]
Patch v1 This patch makes a few tests fail worse than they used to (text failure becomes timeout/ASSERT), but that's okay - It's expected that the tests are still very rough at this stage. The handful of regressions is more than offset by the many tests that now pass.
Brady Eidson
Comment 2
2016-01-22 11:22:28 PST
Created
attachment 269590
[details]
Patch v2
Alex Christensen
Comment 3
2016-01-22 11:46:47 PST
Comment on
attachment 269581
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=269581&action=review
> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:478 > + auto objectStore = m_objectStoresByName.take(objectStoreByIdentifier->info().name());
This is unused.
WebKit Commit Bot
Comment 4
2016-01-22 12:37:53 PST
Comment on
attachment 269590
[details]
Patch v2 Clearing flags on attachment: 269590 Committed
r195467
: <
http://trac.webkit.org/changeset/195467
>
WebKit Commit Bot
Comment 5
2016-01-22 12:37:58 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug