RESOLVED FIXED 152512
FTL B3 does not logicalNot correctly 
https://bugs.webkit.org/show_bug.cgi?id=152512
Summary FTL B3 does not logicalNot correctly
Filip Pizlo
Reported 2015-12-22 13:37:20 PST
It was doing bitNot, which for a 32-bit integer means that 1 turns into -2 and 0 turns into -1, both of which evaluate true.
Attachments
the patch (28.77 KB, patch)
2015-12-22 13:42 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (29.89 KB, patch)
2015-12-22 13:44 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-22 13:42:03 PST
Created attachment 267803 [details] the patch
WebKit Commit Bot
Comment 2 2015-12-22 13:42:51 PST
Attachment 267803 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3Procedure.h:72: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLState.cpp:77: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-12-22 13:44:01 PST
Created attachment 267804 [details] the patch
WebKit Commit Bot
Comment 4 2015-12-22 13:45:29 PST
Attachment 267804 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3Procedure.h:72: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLState.cpp:77: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 5 2015-12-22 13:49:55 PST
Comment on attachment 267803 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267803&action=review r=me > Source/JavaScriptCore/dfg/DFGCommon.h:41 > +#define FTL_USES_B3 1 revert
Filip Pizlo
Comment 6 2015-12-22 14:00:51 PST
Landed in http://trac.webkit.org/changeset/194372
Note You need to log in before you can comment on or make changes to this bug.