RESOLVED FIXED 151393
Snippefy op_mul for the baseline JIT. 
https://bugs.webkit.org/show_bug.cgi?id=151393
Summary Snippefy op_mul for the baseline JIT.
Mark Lam
Reported 2015-11-18 10:24:47 PST
Snippefy op_mul for the baseline JIT.
Attachments
proposed patch. (47.05 KB, patch)
2015-11-18 16:18 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
x86 benchmark result. (63.89 KB, text/plain)
2015-11-18 16:19 PST, Mark Lam 		no flags
Details
x86_64 benchmark result. (64.20 KB, text/plain)
2015-11-18 16:20 PST, Mark Lam 		no flags
Details
x86_64 benchmark result without DFG. (63.65 KB, text/plain)
2015-11-18 16:20 PST, Mark Lam 		no flags
Details
patch 2: with 32-bit build fix. (47.09 KB, patch)
2015-11-18 16:23 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-18 10:28:34 PST
<rdar://problem/23595706>
Mark Lam
Comment 2 2015-11-18 16:18:49 PST
Created attachment 265799 [details] proposed patch.
Mark Lam
Comment 3 2015-11-18 16:19:35 PST
Created attachment 265800 [details] x86 benchmark result.
Mark Lam
Comment 4 2015-11-18 16:20:06 PST
Created attachment 265801 [details] x86_64 benchmark result.
Mark Lam
Comment 5 2015-11-18 16:20:32 PST
Created attachment 265802 [details] x86_64 benchmark result without DFG.
WebKit Commit Bot
Comment 6 2015-11-18 16:21:14 PST
Attachment 265799 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:44: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:52: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:53: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:54: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:55: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 14 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 7 2015-11-18 16:23:44 PST
Created attachment 265804 [details] patch 2: with 32-bit build fix.
WebKit Commit Bot
Comment 8 2015-11-18 16:25:24 PST
Attachment 265804 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:42: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:43: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:44: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:52: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:53: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:54: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITMulGenerator.h:55: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 14 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 9 2015-11-18 16:41:59 PST
Comment on attachment 265804 [details] patch 2: with 32-bit build fix. r=me
Mark Lam
Comment 10 2015-11-18 16:55:20 PST
Thanks for the review. Landed in r192600: <http://trac.webkit.org/r192600>.
Note You need to log in before you can comment on or make changes to this bug.