RESOLVED FIXED 150383
Make table collapsed borders subpixel aware. 
https://bugs.webkit.org/show_bug.cgi?id=150383
Summary Make table collapsed borders subpixel aware.
zalan
Reported 2015-10-20 20:30:08 PDT
Missing from bug 149366.
Attachments
Patch (13.05 KB, patch)
2016-03-05 09:21 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (25.13 KB, patch)
2016-03-05 15:01 PST, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-yosemite (878.15 KB, application/zip)
2016-03-05 16:09 PST, Build Bot 		no flags
Details
Patch (25.12 KB, patch)
2016-03-05 17:17 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2016-02-19 10:52:22 PST
*** Bug 154435 has been marked as a duplicate of this bug. ***
Nikita Vasilyev
Comment 2 2016-03-04 21:34:05 PST
I think this is a duplicate. *** This bug has been marked as a duplicate of bug 154980 ***
zalan
Comment 3 2016-03-04 21:35:59 PST
This is not yet fixed. Making collapsed borders work is a bit more than device pixel snapping at paint time (re bug 154980)
Nikita Vasilyev
Comment 4 2016-03-04 21:37:11 PST
I see. Thanks for the clarification.
zalan
Comment 5 2016-03-04 21:41:53 PST
(In reply to comment #4) > I see. Thanks for the clarification. np. I should have landed the patch for this first and not for bug 154980, but I thought I could make collapsed borders painting work for the generic cases without doing this first, but apparently I even regressed some cases. Will upload a patch soon.
zalan
Comment 6 2016-03-05 09:21:20 PST
Created attachment 273086 [details] Patch
zalan
Comment 7 2016-03-05 09:22:19 PST
(In reply to comment #4) > I see. Thanks for the clarification. Here is the WIP patch. -I need to add some test cases.
zalan
Comment 8 2016-03-05 15:01:51 PST
Created attachment 273099 [details] Patch
Build Bot
Comment 9 2016-03-05 16:09:49 PST
Comment on attachment 273099 [details] Patch Attachment 273099 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/928522 New failing tests: fast/custom-elements/HTMLElement-constructor.html
Build Bot
Comment 10 2016-03-05 16:09:53 PST
Created attachment 273105 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
zalan
Comment 11 2016-03-05 16:11:31 PST
(In reply to comment #9) > Comment on attachment 273099 [details] > Patch > > Attachment 273099 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/928522 > > New failing tests: > fast/custom-elements/HTMLElement-constructor.html I don't believe you EWS!
zalan
Comment 12 2016-03-05 17:17:43 PST
Created attachment 273112 [details] Patch
WebKit Commit Bot
Comment 13 2016-03-05 19:10:12 PST
Comment on attachment 273112 [details] Patch Clearing flags on attachment: 273112 Committed r197627: <http://trac.webkit.org/changeset/197627>
WebKit Commit Bot
Comment 14 2016-03-05 19:10:16 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 15 2016-03-06 10:10:54 PST
Could you please update iOS test results? https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197639%20(3694)/results.html
Alexey Proskuryakov
Comment 16 2016-03-06 10:12:31 PST
I now see that you updated many results already; there are still two or three remaining failures.
zalan
Comment 17 2016-03-06 10:15:18 PST
(In reply to comment #16) > I now see that you updated many results already; there are still two or > three remaining failures. I got a bit confused by these failures. It just occurred to me that we are always in hidpi mode on iOS.
Note You need to log in before you can comment on or make changes to this bug.