RESOLVED FIXED 150097
HTMLPreloadScanner should preload iframes 
https://bugs.webkit.org/show_bug.cgi?id=150097
Summary HTMLPreloadScanner should preload iframes
Chris Dumez
Reported Tuesday, October 13, 2015 9:32:27 PM UTC
HTMLPreloadScanner should preload iframes to decrease page load time.
Attachments
Patch (6.61 KB, patch)
2015-10-13 14:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.88 KB, patch)
2015-10-14 11:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2015-10-15 10:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (672.88 KB, application/zip)
2015-10-15 10:47 PDT, Build Bot 		no flags
Details
Patch (9.10 KB, patch)
2015-10-16 09:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 Tuesday, October 13, 2015 9:32:47 PM UTC
rdar://problem/23094475
Chris Dumez
Comment 2 Tuesday, October 13, 2015 10:52:21 PM UTC
Created attachment 263023 [details] Patch
Chris Dumez
Comment 3 Tuesday, October 13, 2015 10:58:03 PM UTC
I unfortunately did not see an impact on PLT locally.
Antti Koivisto
Comment 4 Wednesday, October 14, 2015 8:24:55 AM UTC
Comment on attachment 263023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263023&action=review > LayoutTests/fast/preloader/frame-src.html:13 > +<html> > +<head> > +<script src="../../resources/js-test-pre.js"></script> > +<script src="http://127.0.0.1:8000/resources/slow-script.pl?delay=100"></script> > +<script> > + shouldBeTrue('internals.isPreloaded("resources/testFrame.html");'); > +</script> > +</head> > +<body> > +<p>Tests that iframes are preloaded.</p> > +<iframe src="resources/testFrame.html"></iframe> > +</body> > +</html> This test verifies that the iframe is preloaded but not that the preloaded resources is actually used (and doesn't just load again). Could you change it so that it verifies this too? This should happen even if the resource is uncacheable (as it often is).
Chris Dumez
Comment 5 Wednesday, October 14, 2015 7:36:29 PM UTC
Created attachment 263091 [details] Patch
Chris Dumez
Comment 6 Wednesday, October 14, 2015 7:37:41 PM UTC
Comment on attachment 263091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263091&action=review > LayoutTests/fast/preloader/frame-src-expected.txt:2 > +testFrame.html has MIME type text/html I now dump the responses so we see the frame is only requested once. Is this sufficient or did you have something else in mind?
Antti Koivisto
Comment 7 Thursday, October 15, 2015 2:48:51 PM UTC
Comment on attachment 263091 [details] Patch It would be also good to have the test ensure that this works when testFrame is served no-store (like it often is).
Chris Dumez
Comment 8 Thursday, October 15, 2015 6:09:40 PM UTC
Created attachment 263167 [details] Patch
Chris Dumez
Comment 9 Thursday, October 15, 2015 6:10:03 PM UTC
(In reply to comment #7) > Comment on attachment 263091 [details] > Patch > > It would be also good to have the test ensure that this works when testFrame > is served no-store (like it often is). Added such test in the patch.
Build Bot
Comment 10 Thursday, October 15, 2015 6:47:39 PM UTC
Comment on attachment 263167 [details] Patch Attachment 263167 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/292013 New failing tests: fast/preloader/frame-src.html
Build Bot
Comment 11 Thursday, October 15, 2015 6:47:43 PM UTC
Created attachment 263172 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Chris Dumez
Comment 12 Friday, October 16, 2015 5:20:57 PM UTC
Created attachment 263273 [details] Patch
WebKit Commit Bot
Comment 13 Friday, October 16, 2015 6:06:43 PM UTC
Comment on attachment 263273 [details] Patch Clearing flags on attachment: 263273 Committed r191180: <http://trac.webkit.org/changeset/191180>
WebKit Commit Bot
Comment 14 Friday, October 16, 2015 6:06:50 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.