RESOLVED FIXED 149594
[GStreamer] Bump internal jhbuild versions to 1.6.3 
https://bugs.webkit.org/show_bug.cgi?id=149594
Summary [GStreamer] Bump internal jhbuild versions to 1.6.3
Philippe Normand
Reported 2015-09-28 03:25:06 PDT
At some point, rather sooner than later :), we should check the tests with the gst 1.6.0 release and bump our jhbuild at least. Later on we could also remove gst < 1.4.x support (if there's still code with a hard-dependency on this).
Attachments
Patch (18.51 KB, patch)
2015-10-20 05:45 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (20.06 KB, patch)
2015-10-22 01:22 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
patch (26.23 KB, patch)
2016-02-18 03:23 PST, Philippe Normand 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-09-28 04:12:55 PDT
I added dependency with bug 149580 because before testing anything related to multimedia we need the tests to work.
Philippe Normand
Comment 2 2015-09-28 04:15:17 PDT
(In reply to comment #1) > I added dependency with bug 149580 because before testing anything related > to multimedia we need the tests to work. That doesn't have much to do with GStreamer. Those tests are related with the UserMediaRequest, higher WK2 API level.
Xabier Rodríguez Calvar
Comment 3 2015-09-28 04:18:11 PDT
(In reply to comment #2) > (In reply to comment #1) > > I added dependency with bug 149580 because before testing anything related > > to multimedia we need the tests to work. > > That doesn't have much to do with GStreamer. Those tests are related with > the UserMediaRequest, higher WK2 API level. Yeah, read too quick, sorry.
ChangSeok Oh
Comment 4 2015-10-20 05:45:14 PDT
Created attachment 263574 [details] Patch
ChangSeok Oh
Comment 5 2015-10-20 05:46:27 PDT
(In reply to comment #4) > Created attachment 263574 [details] > Patch @Philip Please feel free to give it r+ when you think it's ready.
Philippe Normand
Comment 6 2015-10-20 06:09:57 PDT
Have you checked the media tests?
ChangSeok Oh
Comment 7 2015-10-21 04:05:18 PDT
(In reply to comment #6) > Have you checked the media tests? Yes I have. I could not see any regression for the media tests when I tried. BTW do we need to update https://trac.webkit.org/browser/trunk/Source/cmake/FindGStreamer.cmake#L88 as well?
Philippe Normand
Comment 8 2015-10-21 04:08:20 PDT
(In reply to comment #7) > (In reply to comment #6) > > Have you checked the media tests? > > Yes I have. I could not see any regression for the media tests when I tried. > BTW do we need to update > https://trac.webkit.org/browser/trunk/Source/cmake/FindGStreamer.cmake#L88 > as well? Yes, 1.5.x was a development version.
Philippe Normand
Comment 9 2015-10-21 04:20:49 PDT
Also the EWS build failed. Not sure what's going on there.
ChangSeok Oh
Comment 10 2015-10-22 01:22:28 PDT
Created attachment 263807 [details] Patch
ChangSeok Oh
Comment 11 2015-10-22 01:23:30 PDT
(In reply to comment #9) > Also the EWS build failed. Not sure what's going on there. Maybe it needs a clean build?
Philippe Normand
Comment 12 2015-10-22 01:27:54 PDT
(In reply to comment #11) > (In reply to comment #9) > > Also the EWS build failed. Not sure what's going on there. > > Maybe it needs a clean build? I believe patches touching jhbuild modulesets trigger a full rebuild of the dependencies already on the EWS.
Philippe Normand
Comment 13 2015-10-22 01:29:40 PDT
Ah well ignore me :) It's a clean WebKit build that would be needed here.
Philippe Normand
Comment 14 2015-10-22 07:31:00 PDT
Comment on attachment 263807 [details] Patch r=me but please coordinate with the gtk buildbot admins to trigger a clean build when landing this.
ChangSeok Oh
Comment 15 2015-10-23 00:43:15 PDT
(In reply to comment #14) > Comment on attachment 263807 [details] > Patch > > r=me but please coordinate with the gtk buildbot admins to trigger a clean > build when landing this. Hey. philn thanks for the r+. Would you let me know who are the gtk buildbot admins? Maybe kov and KaL?
Philippe Normand
Comment 16 2015-10-23 00:56:09 PDT
Gustavo & Carlos Lopez, now in CC :)
Carlos Alberto Lopez Perez
Comment 17 2015-10-23 03:18:51 PDT
Regarding the buildbots: Any committer can trigger a clean build, you can login with your trac/wiki webkit credentials in the login form that is available in any bot status page. For the EWS, just ping me on the IRC (nick: clopez) after landing it and I will trigger a clean build.
ChangSeok Oh
Comment 18 2015-10-26 01:11:06 PDT
(In reply to comment #17) > Regarding the buildbots: Any committer can trigger a clean build, you can > login with your trac/wiki webkit credentials in the login form that is > available in any bot status page. > > For the EWS, just ping me on the IRC (nick: clopez) after landing it and I > will trigger a clean build. Good to know. Thanks. Here we go. =)
WebKit Commit Bot
Comment 19 2015-10-26 01:58:25 PDT
Comment on attachment 263807 [details] Patch Clearing flags on attachment: 263807 Committed r191576: <http://trac.webkit.org/changeset/191576>
WebKit Commit Bot
Comment 20 2015-10-26 01:58:30 PDT
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 21 2015-10-26 05:04:59 PDT
Reverted r191576 for reason: broke Committed r191583: <http://trac.webkit.org/changeset/191583>
Philippe Normand
Comment 22 2015-10-26 05:06:24 PDT
(In reply to comment #21) > Reverted r191576 for reason: > > broke > > Committed r191583: <http://trac.webkit.org/changeset/191583> Next time I'll remember to quote the revert message when invoking webkit-patch :P
Philippe Normand
Comment 23 2016-02-18 03:23:45 PST
Created attachment 271648 [details] patch
Michael Catanzaro
Comment 24 2016-02-18 06:12:41 PST
Comment on attachment 271648 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=271648&action=review > LayoutTests/platform/gtk/TestExpectations:647 > +webkit.org/b/154390 http/tests/media/reload-after-dialog.html [ Skip ] Instead of marking these as Skip, I would mark them as failing instead, that way we'll notice when they start passing.
Philippe Normand
Comment 25 2016-02-19 00:10:30 PST
Committed r196804: <http://trac.webkit.org/changeset/196804>
Csaba Osztrogonác
Comment 26 2016-02-19 03:59:22 PST
(In reply to comment #25) > Committed r196804: <http://trac.webkit.org/changeset/196804> It broke the build on the 32 bit GTK bot: ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal error: gst/gstconfig.h: No such file or directory #include <gst/gstconfig.h> ^
Philippe Normand
Comment 27 2016-02-19 04:03:56 PST
(In reply to comment #26) > (In reply to comment #25) > > Committed r196804: <http://trac.webkit.org/changeset/196804> > > It broke the build on the 32 bit GTK bot: > > ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal > error: gst/gstconfig.h: No such file or directory > #include <gst/gstconfig.h> > ^ A clean build is needed. I did it on the other bots but forgot this one. Thanks for letting me know.
Carlos Alberto Lopez Perez
Comment 28 2016-02-22 03:27:45 PST
(In reply to comment #27) > (In reply to comment #26) > > (In reply to comment #25) > > > Committed r196804: <http://trac.webkit.org/changeset/196804> > > > > It broke the build on the 32 bit GTK bot: > > > > ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal > > error: gst/gstconfig.h: No such file or directory > > #include <gst/gstconfig.h> > > ^ > > A clean build is needed. I did it on the other bots but forgot this one. > Thanks for letting me know. Seems you forgot also the GTK+ ARM one? It has been failing to build since then. I have just triggered a clean build now.
Note You need to log in before you can comment on or make changes to this bug.