RESOLVED FIXED 149042
[New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks 
https://bugs.webkit.org/show_bug.cgi?id=149042
Summary [New Block-Inside-Inline Model] Self-collapsing block check needs to account ...
Dave Hyatt
Reported 2015-09-10 13:09:42 PDT
Self-collapsing block check needs to account for anonymous inline blocks. For example: <div><i><div></div></i></div> is still self-collapsing even though it has a "line box" with an anonymous inline block on it.
Attachments
Patch (11.49 KB, patch)
2015-09-10 13:14 PDT, Dave Hyatt 		dino: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (889.53 KB, application/zip)
2015-09-10 13:42 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews103 for mac-mavericks (733.00 KB, application/zip)
2015-09-10 13:57 PDT, Build Bot 		no flags
Details
Patch (11.62 KB, patch)
2015-09-10 14:44 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-09-10 13:14:48 PDT
Created attachment 260946 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-10 13:18:11 PDT
Attachment 260946 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:952: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2015-09-10 13:42:32 PDT
Comment on attachment 260946 [details] Patch Attachment 260946 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/158126 New failing tests: fast/text/zero-font-size.html
Build Bot
Comment 4 2015-09-10 13:42:36 PDT
Created attachment 260947 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-09-10 13:57:18 PDT
Comment on attachment 260946 [details] Patch Attachment 260946 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/158155 New failing tests: fast/text/zero-font-size.html
Build Bot
Comment 6 2015-09-10 13:57:21 PDT
Created attachment 260953 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Dave Hyatt
Comment 7 2015-09-10 14:44:15 PDT
Created attachment 260956 [details] Patch
Dave Hyatt
Comment 8 2015-09-10 15:16:18 PDT
Fixed in r189594.
Note You need to log in before you can comment on or make changes to this bug.