WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148070
[CSS Grid Layout] Relayout whenever Box Alignment properties change
https://bugs.webkit.org/show_bug.cgi?id=148070
Summary
[CSS Grid Layout] Relayout whenever Box Alignment properties change
Javier Fernandez
Reported
2015-08-16 15:24:05 PDT
Since we need to resolve 'auto' values on alignment properties at layout time, we must force a relayout whenever these properties change. Additionally, we perform grid items location during the grid container layout, hence we need to trigger it as well if any of these properties chance. However, only stretching implies a size change, so perhaps we can look for smarter ways to re-alig grid items without forcing an expensive relayout.
Attachments
Patch
(37.60 KB, patch)
2015-08-27 07:43 PDT
,
Javier Fernandez
no flags
Details
Formatted Diff
Diff
Patch
(37.75 KB, patch)
2015-09-09 15:18 PDT
,
Javier Fernandez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Javier Fernandez
Comment 1
2015-08-27 07:43:11 PDT
Created
attachment 260054
[details]
Patch
Dave Hyatt
Comment 2
2015-09-09 14:23:47 PDT
Comment on
attachment 260054
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=260054&action=review
r-
> Source/WebCore/rendering/RenderGrid.cpp:285 > + child->setChildNeedsLayout();
This should change to: child->setChildNeedsLayout(MarkOnlyThis). Shouldn't positioned objects be skipped by the for loop? It seems like you are checking all children, but don't you only need to check children that are actually part of the grid?
Javier Fernandez
Comment 3
2015-09-09 15:18:05 PDT
Created
attachment 260879
[details]
Patch
WebKit Commit Bot
Comment 4
2015-09-17 02:13:50 PDT
Comment on
attachment 260879
[details]
Patch Clearing flags on attachment: 260879 Committed
r189910
: <
http://trac.webkit.org/changeset/189910
>
WebKit Commit Bot
Comment 5
2015-09-17 02:13:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug