NEW 148025
Web Inspector: add support for running inspector-test.js tests on Windows 
https://bugs.webkit.org/show_bug.cgi?id=148025
Summary Web Inspector: add support for running inspector-test.js tests on Windows
Blaze Burg
Reported 2015-08-14 08:46:46 PDT
We currently do not load Test.html when running tests, leading tests to time out on Windows because the test page does not receive the "Test Inspector Loaded" signal.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-14 08:46:59 PDT
<rdar://problem/22287523>
Blaze Burg
Comment 2 2015-08-14 08:58:49 PDT
As a starting point, the existing Windows code specifies the page to load inside WebInspectorClient::openInspectorFrontend: RetainPtr<CFURLRef> htmlURLRef = adoptCF(CFBundleCopyResourceURL(webKitBundle(), CFSTR("Main"), CFSTR("html"), CFSTR("WebInspectorUI"))); The mac WK1 code does something like this, which could be copied to Windows. NSString *pagePath = isUnderTest ? [self inspectorTestPagePath] : [self inspectorPagePath];
Blaze Burg
Comment 3 2015-08-14 13:15:38 PDT
To clarify, this bug deals with adding support for tests that use `inspector-test.js`. Another bug tracks `protocol-test.js`, since they use different mechanisms.
Brent Fulgham
Comment 4 2015-12-23 15:52:16 PST
It doesn't look like the "isUnderTest" flag is getting passed to WebKit on Windows. I'll have to see where that comes from.
Blaze Burg
Comment 5 2015-12-27 08:44:24 PST
(In reply to comment #4) > It doesn't look like the "isUnderTest" flag is getting passed to WebKit on > Windows. I'll have to see where that comes from. I'm not sure why this isn't getting propagated. InspectorController has a m_isUnderTest flag, which is set via Internals::setInspectorIsUnderTest. When a frontend opens, it asks the inspected page's inspector controller whether it's under test. I couldn't find any obvious problems here by reading the code again, so you probably want to pause in a debugger inside the setter and getter to see what's going on.
Note You need to log in before you can comment on or make changes to this bug.