RESOLVED FIXED 147447
jsc-tailcall: Don't waste stack space when arity fixup was performed 
https://bugs.webkit.org/show_bug.cgi?id=147447
Summary jsc-tailcall: Don't waste stack space when arity fixup was performed
Basile Clement
Reported 2015-07-30 10:53:39 PDT
Currently when doing a tail call we overwrite only the number of arguments present in the call frame. However, we could have performed an arity fixup and must use the CodeBlock's number of parameters instead if it is higher.
Attachments
Patch (12.17 KB, patch)
2015-07-30 10:56 PDT, Basile Clement 		no flags
DetailsFormatted DiffDiff
Patch (12.45 KB, patch)
2015-07-31 13:13 PDT, Basile Clement 		no flags
DetailsFormatted DiffDiff
Patch (8.72 KB, patch)
2015-07-31 13:21 PDT, Basile Clement 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basile Clement
Comment 1 2015-07-30 10:56:36 PDT
Created attachment 257840 [details] Patch
Michael Saboff
Comment 2 2015-07-30 13:43:29 PDT
Comment on attachment 257840 [details] Patch r=me
Basile Clement
Comment 3 2015-07-30 16:19:49 PDT
Landed in r187618
Basile Clement
Comment 4 2015-07-31 12:13:52 PDT
This is missing the LLInt corresponding changes.
Basile Clement
Comment 5 2015-07-31 12:59:26 PDT
*** Bug 147491 has been marked as a duplicate of this bug. ***
Basile Clement
Comment 6 2015-07-31 13:13:09 PDT
Created attachment 257950 [details] Patch
Basile Clement
Comment 7 2015-07-31 13:21:06 PDT
Created attachment 257953 [details] Patch
Michael Saboff
Comment 8 2015-07-31 13:25:09 PDT
Comment on attachment 257953 [details] Patch r=me
Basile Clement
Comment 9 2015-07-31 13:32:20 PDT
Committed r187676 <http://trac.webkit.org/changeset/187676>
Note You need to log in before you can comment on or make changes to this bug.