NEW 146569
Captions' highlights do not entirely cover their constituent text 
https://bugs.webkit.org/show_bug.cgi?id=146569
Summary Captions' highlights do not entirely cover their constituent text
Myles C. Maxfield
Reported 2015-07-02 18:15:42 PDT
Captions' highlights do not entirely cover their constituent text
Attachments
Patch (30.83 KB, patch)
2015-07-02 18:26 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (30.89 KB, patch)
2015-07-02 18:29 PDT, Myles C. Maxfield 		simon.fraser: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-07-02 18:26:57 PDT
Created attachment 256064 [details] Patch
Myles C. Maxfield
Comment 2 2015-07-02 18:27:42 PDT
<rdar://problem/21498411>
Myles C. Maxfield
Comment 3 2015-07-02 18:29:31 PDT
Created attachment 256065 [details] Patch
Simon Fraser (smfr)
Comment 4 2015-07-02 23:23:14 PDT
Comment on attachment 256065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review > Source/WebCore/ChangeLog:18 > + fallback metrics of its contents. This property, however, requires that the > + span be turned into a div (which is fine because these elements are internal > + to WebKit). Is this OK? Is there ever more than one on a line?
Myles C. Maxfield
Comment 5 2015-07-07 13:34:27 PDT
Comment on attachment 256065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review >> Source/WebCore/ChangeLog:18 >> + to WebKit). > > Is this OK? Is there ever more than one on a line? There is never more than one in a row. See VTTCue::getDisplayTree().
Myles C. Maxfield
Comment 6 2015-07-07 14:43:03 PDT
This actually changes behavior if the text line-wraps.
Myles C. Maxfield
Comment 7 2015-07-07 14:50:16 PDT
Hyatt says that line-box-contain should work on inline elements. I need to figure out why it didn't seem to work for me earlier.
Simon Fraser (smfr)
Comment 8 2015-07-07 14:58:38 PDT
Comment on attachment 256065 [details] Patch r- then!
Myles C. Maxfield
Comment 9 2015-07-07 15:40:00 PDT
line-box-contain only grows the root line box. It doesn't grow the inlineflowboxes which are the things which paint the background.
Myles C. Maxfield
Comment 10 2015-07-07 15:42:42 PDT
hyatt says "honestly if you have a fix that works pretty well, i’d just leave this alone"
Note You need to log in before you can comment on or make changes to this bug.